Skip to content

Commit

Permalink
misc: Update references to Runtime.cachedResources
Browse files Browse the repository at this point in the history
These references will be properly namespace-scoped once [1] is
submitted.

[1]: https://polymer2-chromium-review.googlesource.com/c/chromium/src/+/1829708
  • Loading branch information
TimvdLippe committed Sep 30, 2019
1 parent cb7140b commit 4675754
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion build/build-dt-report-resources.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ const generatorFilename = `./lighthouse-core/report/report-generator.js`;
const htmlReportAssets = require('../lighthouse-core/report/html/html-report-assets.js');

/**
* Used to save cached resources (Runtime.cachedResources).
* Used to save cached resources (Root.Runtime.cachedResources).
* @param {string} name
* @param {string} content
*/
Expand Down
8 changes: 4 additions & 4 deletions clients/devtools-report-assets.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,14 @@

/**
* @fileoverview Instead of loading report assets form the filesystem, in Devtools we must load
* them via Runtime.cachedResources. We use this module to shim
* them via Root.Runtime.cachedResources. We use this module to shim
* lighthouse-core/report/html/html-report-assets.js in Devtools.
*/

/* global Runtime */
/* global Root */

// @ts-ignore: Runtime exists in Devtools.
const cachedResources = Runtime.cachedResources;
// @ts-ignore: Root.Runtime exists in Devtools.
const cachedResources = Root.Runtime.cachedResources;

// Getters are necessary because the DevTools bundling processes
// resources after this module is resolved. These properties are not
Expand Down

0 comments on commit 4675754

Please sign in to comment.