Review changes

GoogleChrome · Mar 29, 2018 · 4893f20 · 4893f20
1 parent 5725bc9
commit 4893f20
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/lighthouse-cli/test/smokehouse/dobetterweb/dbw-expectations.js b/lighthouse-cli/test/smokehouse/dobetterweb/dbw-expectations.js
@@ -35,13 +35,13 @@ module.exports = [
         extendedInfo: {
           value: {
             results: {
-              length: 19,
+              length: '>15',
             },
           },
         },
         details: {
           items: {
-            length: 19,
+            length: '>15',
           },
         },
       },

diff --git a/lighthouse-core/audits/byte-efficiency/uses-optimized-animated-images.js b/lighthouse-core/audits/byte-efficiency/uses-optimized-animated-images.js
@@ -12,7 +12,7 @@ const Audit = require('../audit');
 const WebInspector = require('../../lib/web-inspector');
 
 // the threshold for the size of GIFs wich we flag as unoptimized
-const GIF_BYTE_THRESHOLD = 10 * 1000;
+const GIF_BYTE_THRESHOLD = 10 * 1024;
 
 class UsesOptimizedAnimatedImages extends Audit {
   /**
@@ -22,8 +22,10 @@ class UsesOptimizedAnimatedImages extends Audit {
     return {
       name: 'uses-optimized-animated-images',
       informative: true,
-      description: 'Use a video format for animated content',
-      helpText: 'no help here, your on your own!',
+      description: 'Use a video formats for animated content',
+      helpText: 'Large GIFs are inefficient for delivering animated content. Consider using ' +
+        'MPEG4/WebM videos for animations and PNG/WebP for static images instead of GIF to save ' +
+        'network bytes. [Learn more](https://en.wikipedia.org/wiki/Video_alternative_to_GIF)',
       requiredArtifacts: ['devtoolsLogs'],
     };
   }

diff --git a/lighthouse-core/test/audits/byte-efficiency/uses-optimized-animated-images-test.js b/lighthouse-core/test/audits/byte-efficiency/uses-optimized-animated-images-test.js
@@ -17,7 +17,7 @@ describe('Page uses videos for animated GIFs', () => {
       {
         _resourceType: WebInspector.resourceTypes.Image,
         mimeType: 'image/gif',
-        transferSize: 10000,
+        transferSize: 10240,
       },
       {
         _resourceType: WebInspector.resourceTypes.Image,