core(lib): add chrome-extension to URL allowedProtocols and add test (#…

…6447)
GoogleChrome · Nov 1, 2018 · 5b0105f · 5b0105f
1 parent 76ec168
commit 5b0105f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/lighthouse-core/lib/url-shim.js b/lighthouse-core/lib/url-shim.js
@@ -25,7 +25,7 @@ const listOfTlds = [
 ];
 
 const allowedProtocols = [
-  'https:', 'http:', 'chrome:',
+  'https:', 'http:', 'chrome:', 'chrome-extension:',
 ];
 
 /**

diff --git a/lighthouse-core/test/lib/url-shim-test.js b/lighthouse-core/test/lib/url-shim-test.js
@@ -40,6 +40,7 @@ describe('URL Shim', () => {
     assert.ok(URL.isProtocolAllowed('http://google.com/'));
     assert.ok(URL.isProtocolAllowed('https://google.com/'));
     assert.ok(URL.isProtocolAllowed('chrome://version'));
+    assert.ok(URL.isProtocolAllowed('chrome-extension://blipmdconlkpinefehnmjammfjpmpbjk/popup.html'));
   });
 
   it('safely identifies disallowed URL protocols', () => {
-Original file line number
+Diff line change
@@ Expand Up / @@ -25,7 +25,7 @@ const listOfTlds = [ @@
     ];
     const allowedProtocols = [
-      'https:', 'http:', 'chrome:',
+      'https:', 'http:', 'chrome:', 'chrome-extension:',
     ];
     /**
@@ Expand Down @@