core(constants): increase default maxWaitForFcp to 30s (#9509)

GoogleChrome · Aug 8, 2019 · d8410d5 · d8410d5
1 parent c04f1ab
commit d8410d5
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 6 deletions.
diff --git a/lighthouse-cli/test/cli/__snapshots__/index-test.js.snap b/lighthouse-cli/test/cli/__snapshots__/index-test.js.snap
@@ -1248,7 +1248,7 @@ Object {
     "extraHeaders": null,
     "gatherMode": false,
     "locale": "en-US",
-    "maxWaitForFcp": 15000,
+    "maxWaitForFcp": 30000,
     "maxWaitForLoad": 45000,
     "onlyAudits": null,
     "onlyCategories": null,
@@ -1382,7 +1382,7 @@ Object {
     "extraHeaders": null,
     "gatherMode": false,
     "locale": "en-US",
-    "maxWaitForFcp": 15000,
+    "maxWaitForFcp": 30000,
     "maxWaitForLoad": 45000,
     "onlyAudits": Array [
       "metrics",

diff --git a/lighthouse-core/config/constants.js b/lighthouse-core/config/constants.js
@@ -43,7 +43,7 @@ const throttling = {
 /** @type {LH.Config.Settings} */
 const defaultSettings = {
   output: 'json',
-  maxWaitForFcp: 15 * 1000,
+  maxWaitForFcp: 30 * 1000,
   maxWaitForLoad: 45 * 1000,
   throttlingMethod: 'simulate',
   throttling: throttling.mobileSlow4G,

diff --git a/lighthouse-core/config/lr-desktop-config.js b/lighthouse-core/config/lr-desktop-config.js
@@ -9,6 +9,7 @@
 const config = {
   extends: 'lighthouse:default',
   settings: {
+    maxWaitForFcp: 15 * 1000,
     maxWaitForLoad: 35 * 1000,
     emulatedFormFactor: 'desktop',
     throttling: {

diff --git a/lighthouse-core/config/lr-mobile-config.js b/lighthouse-core/config/lr-mobile-config.js
@@ -9,6 +9,7 @@
 const config = {
   extends: 'lighthouse:default',
   settings: {
+    maxWaitForFcp: 15 * 1000,
     maxWaitForLoad: 35 * 1000,
     // Skip the h2 audit so it doesn't lie to us. See https://github.com/GoogleChrome/lighthouse/issues/6539
     skipAudits: ['uses-http2'],

diff --git a/lighthouse-core/test/results/artifacts/artifacts.json b/lighthouse-core/test/results/artifacts/artifacts.json
@@ -13,7 +13,7 @@
     "output": [
       "html"
     ],
-    "maxWaitForFcp": 15000,
+    "maxWaitForFcp": 30000,
     "maxWaitForLoad": 45000,
     "throttlingMethod": "devtools",
     "throttling": {
@@ -2017,4 +2017,4 @@
     "systemId": "",
     "publicId": ""
   }
-}
+}
diff --git a/lighthouse-core/test/results/sample_v2.json b/lighthouse-core/test/results/sample_v2.json
@@ -3246,7 +3246,7 @@
     "output": [
       "json"
     ],
-    "maxWaitForFcp": 15000,
+    "maxWaitForFcp": 30000,
     "maxWaitForLoad": 45000,
     "throttlingMethod": "devtools",
     "throttling": {