Aspect ratio audit fails on SVG

[peterjanes]

The image aspect ratio audit appears to fail for SVG images. If you run a "best practices" audit on the standalone HTML file in this zip (unzip it and put it on a webserver) you'll see it includes

Does not uses Images with appropriate aspect ratio
Image displayed sizes should match their natural aspect ratio.

I've tried it with different combinations of width/height attributes and CSS, and none can make it pass the audit.

[patrickhulce]

Thanks for reporting @peterjanes! We ignore SVGs for responsive image savings but we should ignore them here too 👍

For any potential first-time bug fixers, we just need to filter out based on mimeType here

lighthouse/lighthouse-core/audits/image-aspect-ratio.js

Lines 73 to 78 in fbe3fda

	// filter out images that don't have following properties
	// networkRecord, width, height, images that use `object-fit`: `cover` or `contain`
	return image.networkRecord &&
	image.width &&
	image.height &&
	!image.usesObjectFit;

[TejasQ]

On it! Is it just the image/svg+xml mimeType to filter out right now, or is there a list of mimeType we want to filter out?

[patrickhulce]

Thanks so much for volunteering @TejasQ but Peter beat you to the punch 😄 feel free to take a look at some of our other good first issues!

[TejasQ]

Thanks @patrickhulce! Missed the reference from @peterjanes!

[leonardorey1970]

Hi all, do you have any idea about when this changes will deployed to prod?.

Cheers!
Leo

[patrickhulce]

@leonardorey1970 should go out with our next release by end of this week in extension and CLI. Chrome stable will get it around end of January.

[leonardorey1970]

Thanks patrickhulce for your reply!