-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give lighthouse an option to ignore certificate errors #559
Comments
Looked into things and I don't think it's possible to do this at runtime. (Currently at least) There is a We can add that in our launcher. Extension users and other folks would be in the dust, but ... that's something. |
There’s also |
we can add whatever into we want into here https://github.com/GoogleChrome/lighthouse/blob/master/lighthouse-core/scripts/launch-chrome.sh#L17 I'm fine with both, fwiw. If we do this, we should log what flags we're launching chrome with so we can be clear with users on the security status. |
isn't launch-chrome.sh set up to pass in args, so you could just do |
Yes you can just run it with the extra arg . Chrome script uses the $@ which makes it possible |
closing as we found a resolution. |
@paulirish It appears these flags wont work when used with the https://groups.google.com/a/chromium.org/forum/#!msg/headless-dev/eiudRsYdc3A/vwKjuELBBgAJ |
@paulirish - any news about |
For the record and for the casual Googler, this is how you can get lighthouse to ignore certificate errors:
|
Hello! @infostreams , I have check your advice and nothing changed Error after run says
lighthouse --version Can anybody help to start lighthouse utility working with incorrect SSL? |
Yeah you need to (unfortunately) revert to an older version of lighthouse for now, see #7292 (comment) - but they're working on fixing it more thoroughly. |
The ssl issue stills there. lighthouse --version |
Same issue on version 5.1.0 with the command:
Insecure document request: The URL you have provided does not have a valid security certificate. This site is missing a valid, trusted certificate (net::ERR_CERT_COMMON_NAME_INVALID). |
The fix was merged immediately after 5.1.0 was released. It will go out with 5.2.0. |
Thanks @patrickhulce, installing the master branch worked for me.
|
Found a force solution.
|
@Kenith all versions of Lighthouse allow you to pass this flag already so that solution should not be necessary. The 5.2.0 change is to allow Lighthouse to continue even though the certificate error is still visible from the DevTools protocol (with the flag present). It's updating the under the hood workings to match the flag's UI effect. |
@patrickhulce Thank you for the feedback. And I am much clear now. |
For me the issue was the old version of Google Chrome (at this moment I have 74 and the latest stable is 83). Updating it made the audit work. |
If people serve the site via a local webserver using a self-signed certificte (e.g. simplehttp2server 🙄), lighthouse just blocks (showing the interstitial in the Chrome instance).
The text was updated successfully, but these errors were encountered: