core(navigation): Add an option to ignore https errors during navigation #7574
Conversation
Adds an option, similar like puppeteer, to ignore https errors during page navigation. I'm still planning to add tests, but opening a PR for discussion. IMO, If the intent is to encourage people to sort out their security, then I think this should be turned into an audit, rather than a hard error.
Janpot
changed the title
|
@patrickhulce could it be that there is a broken/flaky test ( |
Yeah it's only failing on appveyor we've yet to look into it. Debugging appveyor-only failures isn't the easiest/most fun thing to do :) |
Somehow this conflicts with redirectPass
There was a problem hiding this comment.
This looks great to me @Janpot! Might want to hold off on writing tests until there's some other consensus this is the direction we want to go, but I like it 👍
|
@brendankenny @paulirish Any input on how to proceed here? I don't need this merged exactly tomorrow but it would be helpful for me to at least know what's the line of thinking on this of the team. IMO lighthouse should treat security errors in a similar way as the |
|
I think this is great. Asking people to muck with certificates has proven to be too big an ask. I'll go ahead and update this branch w/ master. |
|
+1 for merging this feature, I cannot audit local website with invalidate HTTPS certificate. |
|
+1 please merge :) |
|
I have interesting to merge this pull, because I want to make our website better. |
|
closing in favor of #8865 |
Summary
Adds an option, similar like puppeteer, to ignore https errors during page navigation.
I'm still planning to add tests, but opening a PR for discussion.
IMO, If the intent is to encourage people to sort out their security, then I think this should be turned into an audit, rather than a hard error.
Describe the need for this change
I'd like to be able to run lighthouse on pages that didn't sort out their security yet. And be able to extend lighthouse to include an audit that reflects the chrome security state.
Related Issues/PRs