tests(report-ui-features): fix tools button suite to pass isolated run #10199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n in isolation Problem: the tools button test suite fails when run in isolation, for example: ```bash $ npx jest lighthouse-core/test/report/html/renderer/report-ui-features-test.js -t="tools button" ... Test Suites: 1 failed, 1 total Tests: 15 failed, 15 total ``` Root cause: The tools button test suite setup calls ReportUiFeatures.initFeatures which has an implicit prerequisite on ReportRenderer.renderReport. The prerequisite was coincidentally being met when other test suites in the file invoked the render test helper function. Solution: Invoke the render test helper function in the tools button suite setup.
johnemau
changed the title
johnemau
changed the title
johnemau
changed the title
johnemau
changed the title
patrickhulce
approved these changes
Jan 8, 2020
There was a problem hiding this comment.
Thanks @johnemau!
This LGTM too, but one alternative to consider :)
lighthouse-core/test/report/html/renderer/report-ui-features-test.js
Outdated
Show resolved
Hide resolved
connorjclark
approved these changes
Jan 8, 2020
connorjclark
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem: the tools button test suite fails when run in isolation, for example:
$ npx jest lighthouse-core/test/report/html/renderer/report-ui-features-test.js -t="tools button" ... Test Suites: 1 failed, 1 total Tests: 15 failed, 15 totalRoot cause: The tools button test suite setup calls ReportUiFeatures.initFeatures
which has an implicit prerequisite on ReportRenderer.renderReport.
The prerequisite was coincidentally being met when other test suites in
the file invoked the render test helper function.
Solution: Invoke the render test helper function in the tools button suite setup.
Related Issues/PRs
#9433