core(font-display): dedupe warnings by font origin #11068
Conversation
| 'for the following URL: {fontURL}.', | ||
| undeclaredFontOriginWarning: | ||
| 'Lighthouse was unable to automatically check the {fontCountForOrigin, plural, ' + | ||
| '=1 {`font-display` value for the following origin: {fontOrigin}.} ' + |
There was a problem hiding this comment.
nit: maybe drop both usages of following?
There was a problem hiding this comment.
nit: maybe drop both usages of
following?
yeah, I'm not super in love with the warning text overall, but it's rarely seen enough that I don't have any interest in trying out a whole new sentence. Just dropping 'following' sounds good :)
| undeclaredFontURLWarning: 'Lighthouse was unable to automatically check the font-display value ' + | ||
| 'for the following URL: {fontURL}.', | ||
| undeclaredFontOriginWarning: | ||
| 'Lighthouse was unable to automatically check the {fontCountForOrigin, plural, ' + |
There was a problem hiding this comment.
This is illegal. Can't have text outside a complex ICU message. It should be moved to be repeated in each option.
go/icu-message-migration#message-should-not-have-text-including-whitespaces-andor-placeholders-preceding-or-following-icu-complex-syntax
There was a problem hiding this comment.
This is illegal. Can't have text outside a complex ICU message. It should be moved to be repeated in each option.
arg, makes sense (for those without access, other languages might need to change other parts outside of the brackets to grammatically work with the plural).
Seems like something we could automatically reject in the future.
fixes #9775
as agreed in the bug bash that generated the last issue comment, the vast majority of these warnings are from cross-origin fonts that the audit can't see
font-displayinfo about, so we decided to dedupe by origin.before/after shots:
#9775 oopif smoke test repro
before:
after:
#10812 repro
before:
after:
