misc: add module types declaration #13523
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Feature: Add module declaration file for better typescript support.
The types is generated using below command.
npx /lighthouse-core/index.js --declaration --allowJs --emitDeclarationOnly --outDir types
For current version, if we create a TS project and attempt to import
lighthouse
, it will throw an error about missing module types declararion.TS doc for package.json
types
fieldTS doc for generating
.d.ts
files from.js
filesRelated Issues/PRs
#1773