core(installable-manifest): always run InstallabilityErrors in legacy mode
#13622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
commented
Feb 7, 2022
| reason: manifestValues.parseFailureReason}); | ||
|
|
||
| // If InstallabilityErrors is empty, double check ManifestValues to make sure nothing was missed. | ||
| // InstallabilityErrors can be empty erroneously in our DevTools web tests. |
There was a problem hiding this comment.
For some reason, InstallabilityErrors is empty in our DevTools web tests even though no manifest was fetched. Assuming this is a valid possibility, we can fall back to the old manifest failure reason.
connorjclark
reviewed
Feb 7, 2022
connorjclark
approved these changes
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was investigating why we still have
--invert-match pwa offlineon our FR CI smoke runner. Pretty much everything works since we got rid of the redirect pass. The one exception was the installable manifest audit.We don't run
InstallabilityErrorsin legacy mode if we don't detect a manifest ourselves, soInstallabilityErrorsis just the default empty value. We fill the void ininstallable-manifestwith the "No manifest was fetched" error from our own computed artifactManifestValues.However,
InstallabilityErrorsis always run in FR because it's used as a normal gatherer. The audit will then have 2 errors in FR, "Page has no manifest URL" fromInstallabilityErrorsand "No manifest was fetched" fromManifestValues.I think the best solution is to run
InstallabilityErrorsevery time in legacy mode, and get rid of theManifestValuesdependency ininstallable-manifest.Related
#12861
#11313