Resolve audit result #487
Merged
Resolve audit result #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| throw new Error('generateAuditResult requires a rawValue'); | ||
| } | ||
|
|
||
| let score = result.score ? result.score : result.rawValue; |
There was a problem hiding this comment.
should probably use an undefined check as to not discard possible scores of 0
wardpeet
force-pushed
the
resolve-audit-result
branch
from
422cfd1 to
53fa9c5
Compare
|
Updated :) |
|
Looks like it fails tests :( |
wardpeet
force-pushed
the
resolve-audit-result
branch
from
53fa9c5 to
3ebfdba
Compare
|
Forgot to push :'( waiting for the build :) |
wardpeet
force-pushed
the
resolve-audit-result
branch
from
3ebfdba to
54a0ff2
Compare
|
awesome stuff. A massive cleanup. Thanks for this |
addyosmani
added a commit
that referenced
this pull request
Jul 20, 2016
addyosmani
added a commit
that referenced
this pull request
Jul 20, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #458
No idea if I did any good but basically this is what i've done.
Every value is mapped to rawValue (so value => rawValue).
Score is equal to score, if no score is set we fallback to rawValue
display value uses rawvalue with minor adaptation like adding ms or fallbacks to string representation of rawValue. If displayValue === score we make it empty so we don't display it in our reporting