Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(tsc): add tsc type checking to report #5195

Merged
merged 7 commits into from
May 17, 2018
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ script:
- yarn lint
- yarn unit:silentcoverage
- yarn type-check
- yarn closure
- yarn diff:sample-json
- yarn smoke:silentcoverage
- yarn test-extension
Expand Down
101 changes: 0 additions & 101 deletions lighthouse-core/closure/closure-type-checking.js

This file was deleted.

31 changes: 0 additions & 31 deletions lighthouse-core/closure/conformance_config.textproto

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@ class Simulator {

options = Object.assign({flexibleOrdering: false}, options);
// initialize the necessary data containers
this._flexibleOrdering = options.flexibleOrdering;
this._flexibleOrdering = !!options.flexibleOrdering;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated tsc was stricter here

this._initializeConnectionPool(graph);
this._initializeAuxiliaryData();

Expand Down
Loading