Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(violation-audit): de-dupe items by URL and label #5219

Merged
merged 3 commits into from
May 15, 2018
Merged

core(violation-audit): de-dupe items by URL and label #5219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3b1ec70
core(violation-audit): de-dupe items by URL and label
patrickhulce May 15, 2018
dcca4ec
remove unnecessary properties
patrickhulce May 15, 2018
1060df5
golden lhr
patrickhulce May 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions lighthouse-core/audits/violation-audit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,22 @@ class ViolationAudit extends Audit {
/**
* @param {LH.Artifacts} artifacts
* @param {RegExp} pattern
* @return {Array<LH.Crdp.Log.LogEntry & {label: string}>}
* @return {Array<{label: string, url?: string}>}
*/
static getViolationResults(artifacts, pattern) {
const seen = new Set();
return artifacts.ChromeConsoleMessages
.map(message => message.entry)
.filter(entry => entry.url && entry.source === 'violation' && pattern.test(entry.text))
.map(entry => Object.assign({label: `line: ${entry.lineNumber}`}, entry));
.map(entry => ({label: `line: ${entry.lineNumber}`, url: entry.url}))
.filter(entry => {
// Filter out duplicate entries by URL/label since they are not differentiable to the user
// @see https://github.com/GoogleChrome/lighthouse/issues/5218
const key = `${entry.url}!${entry.label}`;
if (seen.has(key)) return false;
seen.add(key);
return true;
});
}
}

Expand Down
1 change: 1 addition & 0 deletions lighthouse-core/test/audits/dobetterweb/uses-passive-event-listeners-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ describe('Page uses passive events listeners where applicable', () => {
ChromeConsoleMessages: [
{entry: {source: 'violation', url: 'https://example.com/', text}},
{entry: {source: 'violation', url: 'https://example2.com/two', text}},
{entry: {source: 'violation', url: 'https://example2.com/two', text}}, // duplicate
{entry: {source: 'violation', url: 'http://abc.com/', text: 'No document.write'}},
{entry: {source: 'deprecation', url: 'https://example.com/two'}},
],
Expand Down
225 changes: 9 additions & 216 deletions lighthouse-core/test/results/sample_v2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2314,57 +2314,11 @@
"items": [
{
"label": "line: 277",
"source": "violation",
"level": "verbose",
"text": "Only request geolocation information in response to a user gesture.",
"timestamp": 1519974785839.5,
"url": "http://localhost:10200/dobetterweb/dbw_tester.html",
"lineNumber": 277,
"stackTrace": {
"callFrames": [
{
"functionName": "geolocationOnStartTest",
"scriptId": "29",
"url": "http://localhost:10200/dobetterweb/dbw_tester.html",
"lineNumber": 277,
"columnNumber": 24
},
{
"functionName": "",
"scriptId": "29",
"url": "http://localhost:10200/dobetterweb/dbw_tester.html",
"lineNumber": 345,
"columnNumber": 2
}
]
}
"url": "http://localhost:10200/dobetterweb/dbw_tester.html"
},
{
"label": "line: 281",
"source": "violation",
"level": "verbose",
"text": "Only request geolocation information in response to a user gesture.",
"timestamp": 1519974785840.8,
"url": "http://localhost:10200/dobetterweb/dbw_tester.html",
"lineNumber": 281,
"stackTrace": {
"callFrames": [
{
"functionName": "geolocationOnStartTest",
"scriptId": "29",
"url": "http://localhost:10200/dobetterweb/dbw_tester.html",
"lineNumber": 281,
"columnNumber": 40
},
{
"functionName": "",
"scriptId": "29",
"url": "http://localhost:10200/dobetterweb/dbw_tester.html",
"lineNumber": 345,
"columnNumber": 2
}
]
}
"url": "http://localhost:10200/dobetterweb/dbw_tester.html"
}
]
}
Expand Down Expand Up @@ -2393,84 +2347,15 @@
"items": [
{
"label": "line: 178",
"source": "violation",
"level": "verbose",
"text": "Avoid using document.write().",
"timestamp": 1519974785808.58,
"url": "http://localhost:10200/dobetterweb/dbw_tester.html",
"lineNumber": 178,
"stackTrace": {
"callFrames": [
{
"functionName": "documentWriteTest",
"scriptId": "29",
"url": "http://localhost:10200/dobetterweb/dbw_tester.html",
"lineNumber": 178,
"columnNumber": 11
},
{
"functionName": "",
"scriptId": "29",
"url": "http://localhost:10200/dobetterweb/dbw_tester.html",
"lineNumber": 339,
"columnNumber": 2
}
]
}
"url": "http://localhost:10200/dobetterweb/dbw_tester.html"
},
{
"label": "line: 179",
"source": "violation",
"level": "verbose",
"text": "Avoid using document.write().",
"timestamp": 1519974785809.4,
"url": "http://localhost:10200/dobetterweb/dbw_tester.html",
"lineNumber": 179,
"stackTrace": {
"callFrames": [
{
"functionName": "documentWriteTest",
"scriptId": "29",
"url": "http://localhost:10200/dobetterweb/dbw_tester.html",
"lineNumber": 179,
"columnNumber": 11
},
{
"functionName": "",
"scriptId": "29",
"url": "http://localhost:10200/dobetterweb/dbw_tester.html",
"lineNumber": 339,
"columnNumber": 2
}
]
}
"url": "http://localhost:10200/dobetterweb/dbw_tester.html"
},
{
"label": "line: 180",
"source": "violation",
"level": "verbose",
"text": "Avoid using document.write().",
"timestamp": 1519974785810.25,
"url": "http://localhost:10200/dobetterweb/dbw_tester.html",
"lineNumber": 180,
"stackTrace": {
"callFrames": [
{
"functionName": "documentWriteTest",
"scriptId": "29",
"url": "http://localhost:10200/dobetterweb/dbw_tester.html",
"lineNumber": 180,
"columnNumber": 11
},
{
"functionName": "",
"scriptId": "29",
"url": "http://localhost:10200/dobetterweb/dbw_tester.html",
"lineNumber": 339,
"columnNumber": 2
}
]
}
"url": "http://localhost:10200/dobetterweb/dbw_tester.html"
}
]
}
Expand Down Expand Up @@ -2632,30 +2517,7 @@
"items": [
{
"label": "line: 287",
"source": "violation",
"level": "verbose",
"text": "Only request notification permission in response to a user gesture.",
"timestamp": 1519974785841.72,
"url": "http://localhost:10200/dobetterweb/dbw_tester.html",
"lineNumber": 287,
"stackTrace": {
"callFrames": [
{
"functionName": "notificationOnStartTest",
"scriptId": "29",
"url": "http://localhost:10200/dobetterweb/dbw_tester.html",
"lineNumber": 287,
"columnNumber": 15
},
{
"functionName": "",
"scriptId": "29",
"url": "http://localhost:10200/dobetterweb/dbw_tester.html",
"lineNumber": 346,
"columnNumber": 2
}
]
}
"url": "http://localhost:10200/dobetterweb/dbw_tester.html"
}
]
}
Expand Down Expand Up @@ -2802,84 +2664,15 @@
"items": [
{
"label": "line: 26",
"source": "violation",
"level": "verbose",
"text": "Added non-passive event listener to a scroll-blocking 'wheel' event. Consider marking event handler as 'passive' to make the page more responsive. See https://www.chromestatus.com/feature/5745543795965952",
"timestamp": 1519974785779.5,
"url": "http://localhost:10200/dobetterweb/dbw_tester.js",
"lineNumber": 26,
"stackTrace": {
"callFrames": [
{
"functionName": "",
"scriptId": "25",
"url": "http://localhost:10200/dobetterweb/dbw_tester.js",
"lineNumber": 26,
"columnNumber": 11
},
{
"functionName": "",
"scriptId": "25",
"url": "http://localhost:10200/dobetterweb/dbw_tester.js",
"lineNumber": 39,
"columnNumber": 2
}
]
}
"url": "http://localhost:10200/dobetterweb/dbw_tester.js"
},
{
"label": "line: 222",
"source": "violation",
"level": "verbose",
"text": "Added non-passive event listener to a scroll-blocking 'wheel' event. Consider marking event handler as 'passive' to make the page more responsive. See https://www.chromestatus.com/feature/5745543795965952",
"timestamp": 1519974785837.14,
"url": "http://localhost:10200/dobetterweb/dbw_tester.html",
"lineNumber": 222,
"stackTrace": {
"callFrames": [
{
"functionName": "passiveEventsListenerTest",
"scriptId": "29",
"url": "http://localhost:10200/dobetterweb/dbw_tester.html",
"lineNumber": 222,
"columnNumber": 9
},
{
"functionName": "",
"scriptId": "29",
"url": "http://localhost:10200/dobetterweb/dbw_tester.html",
"lineNumber": 344,
"columnNumber": 2
}
]
}
"url": "http://localhost:10200/dobetterweb/dbw_tester.html"
},
{
"label": "line: 248",
"source": "violation",
"level": "verbose",
"text": "Added non-passive event listener to a scroll-blocking 'touchmove' event. Consider marking event handler as 'passive' to make the page more responsive. See https://www.chromestatus.com/feature/5745543795965952",
"timestamp": 1519974785837.83,
"url": "http://localhost:10200/dobetterweb/dbw_tester.html",
"lineNumber": 248,
"stackTrace": {
"callFrames": [
{
"functionName": "passiveEventsListenerTest",
"scriptId": "29",
"url": "http://localhost:10200/dobetterweb/dbw_tester.html",
"lineNumber": 248,
"columnNumber": 5
},
{
"functionName": "",
"scriptId": "29",
"url": "http://localhost:10200/dobetterweb/dbw_tester.html",
"lineNumber": 344,
"columnNumber": 2
}
]
}
"url": "http://localhost:10200/dobetterweb/dbw_tester.html"
}
]
}
Expand Down