-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core(a11y): add back html/tags/impact #5439
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1224,17 +1224,25 @@ | |
| "type": "node", | ||
| "selector": "div > h2", | ||
| "path": "3,HTML,1,BODY,0,DIV,0,H2", | ||
| "snippet": "<h2>" | ||
| "snippet": "<h2>Do better web tester page</h2>", | ||
| "explanation": "Fix any of the following:\n Element has insufficient color contrast of 1.32 (foreground color: #ffc0cb, background color: #eeeeee, font size: 18.0pt, font weight: bold). Expected contrast ratio of 3:1" | ||
| } | ||
| }, | ||
| { | ||
| "node": { | ||
| "type": "node", | ||
| "selector": "div > span", | ||
| "path": "3,HTML,1,BODY,0,DIV,1,SPAN", | ||
| "snippet": "<span>" | ||
| "snippet": "<span>Hi there!</span>", | ||
| "explanation": "Fix any of the following:\n Element has insufficient color contrast of 1.32 (foreground color: #ffc0cb, background color: #eeeeee, font size: 12.0pt, font weight: normal). Expected contrast ratio of 4.5:1" | ||
| } | ||
| } | ||
| ], | ||
| "impact": "serious", | ||
| "tags": [ | ||
| "cat.color", | ||
| "wcag2aa", | ||
| "wcag143" | ||
| ] | ||
| } | ||
| }, | ||
|
|
@@ -1310,9 +1318,16 @@ | |
| "type": "node", | ||
| "selector": "html", | ||
| "path": "3,HTML", | ||
| "snippet": "<html manifest=\"clock.appcache\">" | ||
| "snippet": "<html manifest=\"clock.appcache\">", | ||
| "explanation": "Fix any of the following:\n The <html> element does not have a lang attribute" | ||
| } | ||
| } | ||
| ], | ||
| "impact": "serious", | ||
| "tags": [ | ||
| "cat.language", | ||
| "wcag2a", | ||
| "wcag311" | ||
| ] | ||
| } | ||
| }, | ||
|
|
@@ -1346,25 +1361,36 @@ | |
| "type": "node", | ||
| "selector": "body > img[src$=\"lighthouse-480x318.jpg\"]:nth-child(5)", | ||
| "path": "3,HTML,1,BODY,5,IMG", | ||
| "snippet": "<img src=\"lighthouse-480x318.jpg\" width=\"480\" height=\"57\">" | ||
| "snippet": "<img src=\"lighthouse-480x318.jpg\" width=\"480\" height=\"57\">", | ||
| "explanation": "Fix any of the following:\n Element does not have an alt attribute\n aria-label attribute does not exist or is empty\n aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty or not visible\n Element has no title attribute or the title attribute is empty\n Element's default semantics were not overridden with role=\"presentation\"\n Element's default semantics were not overridden with role=\"none\"" | ||
| } | ||
| }, | ||
| { | ||
| "node": { | ||
| "type": "node", | ||
| "selector": "body > img[src$=\"lighthouse-480x318.jpg\"]:nth-child(6)", | ||
| "path": "3,HTML,1,BODY,7,IMG", | ||
| "snippet": "<img src=\"lighthouse-480x318.jpg\" width=\"480\" height=\"318\">" | ||
| "snippet": "<img src=\"lighthouse-480x318.jpg\" width=\"480\" height=\"318\">", | ||
| "explanation": "Fix any of the following:\n Element does not have an alt attribute\n aria-label attribute does not exist or is empty\n aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty or not visible\n Element has no title attribute or the title attribute is empty\n Element's default semantics were not overridden with role=\"presentation\"\n Element's default semantics were not overridden with role=\"none\"" | ||
| } | ||
| }, | ||
| { | ||
| "node": { | ||
| "type": "node", | ||
| "selector": "body > img:nth-child(20)", | ||
| "path": "3,HTML,1,BODY,36,IMG", | ||
| "snippet": "<img src=\"blob:http://localhost:10200/ae0eac03-ab9b-4a6a-b299-f5212153e277\">" | ||
| "snippet": "<img src=\"blob:http://localhost:10200/ae0eac03-ab9b-4a6a-b299-f5212153e277\">", | ||
| "explanation": "Fix any of the following:\n Element does not have an alt attribute\n aria-label attribute does not exist or is empty\n aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty or not visible\n Element has no title attribute or the title attribute is empty\n Element's default semantics were not overridden with role=\"presentation\"\n Element's default semantics were not overridden with role=\"none\"" | ||
| } | ||
| } | ||
| ], | ||
| "impact": "critical", | ||
| "tags": [ | ||
| "cat.text-alternatives", | ||
| "wcag2a", | ||
| "wcag111", | ||
| "section508", | ||
| "section508.22.a" | ||
| ] | ||
| } | ||
| }, | ||
|
|
@@ -1398,25 +1424,37 @@ | |
| "type": "node", | ||
| "selector": "body > input[type=\"password\"]:nth-child(17)", | ||
| "path": "3,HTML,1,BODY,31,INPUT", | ||
| "snippet": "<input type=\"password\" onpaste=\"event.preventDefault();\">" | ||
| "snippet": "<input type=\"password\" onpaste=\"event.preventDefault();\">", | ||
| "explanation": "Fix any of the following:\n aria-label attribute does not exist or is empty\n aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty or not visible\n Form element does not have an implicit (wrapped) <label>\n Form element does not have an explicit <label>\n Element has no title attribute or the title attribute is empty" | ||
| } | ||
| }, | ||
| { | ||
| "node": { | ||
| "type": "node", | ||
| "selector": "body > input[type=\"password\"]:nth-child(18)", | ||
| "path": "3,HTML,1,BODY,33,INPUT", | ||
| "snippet": "<input type=\"password\">" | ||
| "snippet": "<input type=\"password\">", | ||
| "explanation": "Fix any of the following:\n aria-label attribute does not exist or is empty\n aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty or not visible\n Form element does not have an implicit (wrapped) <label>\n Form element does not have an explicit <label>\n Element has no title attribute or the title attribute is empty" | ||
| } | ||
| }, | ||
| { | ||
| "node": { | ||
| "type": "node", | ||
| "selector": "body > input[type=\"password\"]:nth-child(19)", | ||
| "path": "3,HTML,1,BODY,35,INPUT", | ||
| "snippet": "<input type=\"password\" onpaste=\"return false;\">" | ||
| "snippet": "<input type=\"password\" onpaste=\"return false;\">", | ||
| "explanation": "Fix any of the following:\n aria-label attribute does not exist or is empty\n aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty or not visible\n Form element does not have an implicit (wrapped) <label>\n Form element does not have an explicit <label>\n Element has no title attribute or the title attribute is empty" | ||
| } | ||
| } | ||
| ], | ||
| "impact": "critical", | ||
| "tags": [ | ||
| "cat.forms", | ||
| "wcag2a", | ||
| "wcag332", | ||
| "wcag131", | ||
| "section508", | ||
| "section508.22.n" | ||
| ] | ||
| } | ||
| }, | ||
|
|
@@ -1450,17 +1488,29 @@ | |
| "type": "node", | ||
| "selector": "body > a:nth-child(15)", | ||
| "path": "3,HTML,1,BODY,27,A", | ||
| "snippet": "<a href=\"javascript:void(0)\" target=\"_blank\">" | ||
| "snippet": "<a href=\"javascript:void(0)\" target=\"_blank\"></a>", | ||
| "explanation": "Fix all of the following:\n Element is in tab order and does not have accessible text\n\nFix any of the following:\n Element does not have text that is visible to screen readers\n aria-label attribute does not exist or is empty\n aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty or not visible\n Element's default semantics were not overridden with role=\"presentation\"\n Element's default semantics were not overridden with role=\"none\"" | ||
| } | ||
| }, | ||
| { | ||
| "node": { | ||
| "type": "node", | ||
| "selector": "body > a[href$=\"mailto:[email protected]\"]", | ||
| "path": "3,HTML,1,BODY,29,A", | ||
| "snippet": "<a href=\"mailto:[email protected]\" target=\"_blank\">" | ||
| "snippet": "<a href=\"mailto:[email protected]\" target=\"_blank\"></a>", | ||
| "explanation": "Fix all of the following:\n Element is in tab order and does not have accessible text\n\nFix any of the following:\n Element does not have text that is visible to screen readers\n aria-label attribute does not exist or is empty\n aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty or not visible\n Element's default semantics were not overridden with role=\"presentation\"\n Element's default semantics were not overridden with role=\"none\"" | ||
| } | ||
| } | ||
| ], | ||
| "impact": "serious", | ||
| "tags": [ | ||
| "cat.name-role-value", | ||
| "wcag2a", | ||
| "wcag111", | ||
| "wcag412", | ||
| "wcag244", | ||
| "section508", | ||
| "section508.22.a" | ||
| ] | ||
| } | ||
| }, | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should
impactandtagsbe nested or something? I don't really have an opinion, this seems fine and nesting might not be any better, but it may be putting us on a path towarddetailsbecoming the new grab bag :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, I like it where it is.
If it were nested, I can't think of what it would be called. On Deque's site "impact" and "tags" meta is extrapolated to create the "Compliance Data & User Impact" column. "complianceUserImpact:" seems a little long anyway ;-)