extension: fix 'Couldn't resolve current tab'

[wardpeet]

Summary

bugfix

it fixes the cannot resolve tab issue in the extension

Related Issues/PRs

fixes #5668

This fix makes it easier to get this bug #5872

[brendankenny]

this avoids the issue for the URL (always using the version queried and stored when the popup first opens), but does this solve the issue of not being able to resolve the tab?

runLighthouseInExtension() creates the ExtensionProtocol connection, but it's not until gatherRunner.run() -> driver.connect() -> connection.connect() -> _getCurrentTabId() -> _queryCurrentTab() that it gets the tab ID to attach to. Based on your investigation in #5668 (comment) it seems like that query would fail at that point if the user has lost access to the tab?

[brendankenny]

Maybe popup.js could also query and save the tab ID and the ExtensionProtocol constructor could take that as an argument, rather than trying to get it itself. We'd have to think through if there are downsides to that rather than letting it take care of itself...

[wardpeet]

Not 100% sure what you're referring too. We fail on the first call const url = await connection.getCurrentTabURL(); lighthouse-ext-background.js#L67.

the tabid can still be resolved just fine so that's why I did not add it as a parameter but i'm not against it. We should validate if the tabid is still available that's all, I can't think of a downside atm.

[GodLesZ]

Any progress on this @brendankenny @wardpeet ?
Just getting the error all the time and a fix would be rly nice

[wardpeet]

@GodLesZ could you tell us which site you're auditing and what extensions you have ?

[GodLesZ]

@GodLesZ could you tell us which site you're auditing and what extensions you have ?

I'm testing the chrome extension on the latest chrome (already tested on canary & stable) and always get this error.
Maybe this is related to the fact, that the SSL certificate of the (only local accessible) page is not valid?

Currently we're not able to get lighthouse reports of untrusted websites, so I hope this extension is able to generate this?

[brendankenny]

At this point, I don't think we're going to move on this :)