core: remove some trivial uses of WebInspector #6090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
requested review from
patrickhulce and
paulirish
as code owners
brendankenny
commented
Sep 22, 2018
| @@ -6,13 +6,10 @@ | |||
| 'use strict'; | |||
|
|
|||
| /** @typedef {LH.Artifacts.FontSize['analyzedFailingNodesData'][0]} FailingNodeData */ | |||
| /** @typedef {{Type: {Regular: 'Regular', Inline: 'Inline', Attributes: 'Attributes'}}} WebInspectorCSSStyle */ | |||
There was a problem hiding this comment.
The values that are compared against these are typed to only be one of these values, so really no point in bringing it in just for these three constants.
brendankenny
commented
Sep 22, 2018
| @@ -47,10 +46,6 @@ class NetworkRecorder extends EventEmitter { | |||
| return super.once(event, listener); | |||
| } | |||
|
|
|||
| get EventTypes() { | |||
brendankenny
commented
Sep 22, 2018
| Injected: 'injected', | ||
| UserAgent: 'user-agent', | ||
| Inspector: 'inspector', | ||
| Regular: 'regular', |
There was a problem hiding this comment.
these shouldn't have been all caps (see e.g. https://github.com/ChromeDevTools/devtools-frontend/blob/51d3d758c57dc51d1864b3003de1fdda82963623/front_end/sdk/CSSRule.js#L70). We only touch the code that checks if a style was injected or came from the user-agent, but unsure if that was affecting the output of our font-size code...
|
bundle size form 512.65KB back down to 510.01KB :) |
paulirish
reviewed
Sep 22, 2018
|
that's not a review :P |
paulirish
approved these changes
Sep 22, 2018
brendankenny
force-pushed
the
lessinspector
branch
from
523d474 to
61c6b93
Compare
|
❤️ this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inspired by @patrickhulce's comment in #5946 (comment), took a look at some of our current uses of WebInspector and found some that could be trivially removed.