-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
report(redesign): respect prefers-color-scheme #8842
Conversation
really Can you move it in here? Not sure what's the best way to do it...e.g check for `.score100', maybe? |
done. can I remove the check for devtools too? |
Co-Authored-By: Hoten <[email protected]>
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
@paulirish fixed |
@hoten your merge added back the test that was removed https://github.com/GoogleChrome/lighthouse/pull/8842/files#diff-219d90e30aff619017455031ea860fec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
what's up with travis though, a push 2 hours ago and still pending?
FYI Chrome 76 will support |
You can test this in FF 67 beta. Just need to change OS to dark mode (for osx, Appearance -> Dark)