Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report: logically order css variables #9232

Merged
merged 2 commits into from
Jun 20, 2019
Merged

Conversation

connorjclark
Copy link
Collaborator

ahhhh report-styles.css. isn't she beautiful (now)?

Don't squash - the first commit has a few renames I missed.

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@paulirish
Copy link
Member

Don't squash - the first commit has a few renames I missed.

you have a commit with the message report: create naming convention for css variables (#9149) which is identical to a different commit on master

i think that commit should be titled as

report: naming convention (#9149) followup fixes

if you fixup that message I can land these two commits separately.

@connorjclark connorjclark force-pushed the styles-refactor-part-3 branch from 2871a51 to 4ddad97 Compare June 19, 2019 23:59
@connorjclark
Copy link
Collaborator Author

done

@paulirish paulirish merged commit ece89ec into master Jun 20, 2019
@paulirish paulirish deleted the styles-refactor-part-3 branch June 20, 2019 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants