Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: fix typo in performance-budget smoke test #9244

Merged
merged 2 commits into from
Jun 26, 2019
Merged

misc: fix typo in performance-budget smoke test #9244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c33ee60
misc: ArrayBuffer.byteLength instead of .length in perf budge smoke test
connorjclark Jun 21, 2019
e99cfcb
simplify changes
connorjclark Jun 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lighthouse-cli/test/fixtures/perf/perf-budgets/load-things.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
// Load file as 'other' resource.
const response = await fetch('http://localhost:10503/preload.html');
const ab = await response.arrayBuffer();
document.querySelector('#corsfont').textContent = ab.length;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change is just about text and doesn't matter at all right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk, would the font be loaded if there were no text?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, oh I see what I'm missing now sorry :)

  1. new ArrayBuffer().length === undefined, not just a semantic difference like in node
  2. el.textContent = undefined clears all textContent, and does not do some sort of string coercion to "undefined"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

el.textContent = undefined clears all textContent, and does not do some sort of string coercion to "undefined"

just to be clear, while the actual behavior is unintended and pointless, the intended behavior was also pointless. There's no reason to add this to the page at all, just making sure (poorly, it turns out) the thing is actually loaded and used :)

document.querySelector('.fetch-length').textContent = ab.byteLength;
}
yah();
</script>
Expand All @@ -40,7 +40,7 @@
<img style="width: 100px; height: 100px;" src="../../byte-efficiency/large.svg">
<p class="webfont">Ripping off some webfont smoke tests</p>
<p><strong class="webfont">Do we need such text</strong></p>
<p id="corsfont"></p>
<p class="fetch-length"></p>
<script src="../level-2.js"></script>
</body>
</html>
2 changes: 1 addition & 1 deletion lighthouse-cli/test/smokehouse/perf/expectations.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ module.exports = [
{
resourceType: 'document',
countOverBudget: '1 request',
sizeOverBudget: '1100±50',
sizeOverBudget: '1150±50',
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added just enough bytes to the main doc to require this change

},
{
resourceType: 'stylesheet',
Expand Down