-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n: axe 3.3 #9385
i18n: axe 3.3 #9385
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
I signed it! 😃 |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely blocked behind #9114 (as we don't want to round trip these changes to our translators without placeholders), but this looks fine to me. Revert all the files under locales/*.json
, we update those with the translation updates.
Once #9114 lands you should be able to revert all locales/*.json
files and then run yarn i18n
to update the en-US
and en-XL
files and make sure everything is 100%.
I also think this overlaps heavily/totally with #9084. Which I think we'll prefer. @egsweeny @paulirish ?
@exterkamp oh, didn't know about #9084 , my bad! I guess we can close this one then as it doesn't make much sense. |
Okay, SGTM. Sorry that #9084 was kinda hidden! Thanks for the PR, we definitely appreciate the effort and involvement! |
@Elfo404 Found something that relates to this though. In web.dev, articles on Lighthouse a11y, they point to axe 3.2 at the bottom: They might want a bug/PR to update those links to 3.3 since thats what LH uses now. (I only did a brief check if this is on their radar already, so I'd ask before making a PR so that this kind of thing doesn't happen again over there jsyk) |
Summary
Changes axe urls to 3.3