-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v5.2.0 #9442
v5.2.0 #9442
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
changelog.md
Outdated
* `page-functions`: don't try to clone a ShadowRoot ([#9079](https://github.com/googlechrome/lighthouse/pull/9079)) | ||
* perf: speed up `tap-target`'s `isVisible()` ([#9056](https://github.com/googlechrome/lighthouse/pull/9056)) | ||
* tracehouse: allow missing FCP ([#9174](https://github.com/googlechrome/lighthouse/pull/9174)) | ||
* tracehouse: move and organize files in `lib/tracehouse/` ([9f80524](https://github.com/googlechrome/lighthouse/commit/9f80524), [1af2edd](https://github.com/googlechrome/lighthouse/commit/1af2edd), [7ba6776](https://github.com/googlechrome/lighthouse/commit/7ba6776), [ddff3d6](https://github.com/googlechrome/lighthouse/commit/ddff3d6)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this should be called out at all more if folks were relying on the path to do their own trace parsing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this should be called out at all more if folks were relying on the path to do their own trace parsing?
done
did we want to start saying the expected chrome release this will be in?
|
added a notable changes section and tried to give fuller descriptions to those and the new audits. Let me know what you think :)
Good idea. I vaguely recall a style guide somewhere about referring to Chrome releases without the M, so reworded slightly. I can change it more, though |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit, but LGTM
changelog.md
Outdated
|
||
* introduce script to swap in new locale to LHR ([#8755](https://github.com/googlechrome/lighthouse/pull/8755)) | ||
* enable local debug locale, `en-XL` ([#9192](https://github.com/googlechrome/lighthouse/pull/9192)) | ||
* localize audits in `best-practices` ([#9092](https://github.com/googlechrome/lighthouse/pull/9092)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So they are prepped for translation, but not translated. Could add a disclaimer:
Note: best-practices audits are not yet translated to all languages in this release. Expected to be translated fully next release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done (but shorter :)
🎉