Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(audits): point PWA audit description links to web.dev #9539

Merged
merged 5 commits into from
Aug 24, 2019
Merged

core(audits): point PWA audit description links to web.dev #9539

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4ce5e97
core(audits): Point PWA audit links to web.dev
mfriesenhahn Aug 9, 2019
27c42b3
Merge branch 'master' into audit-links-pwa
mfriesenhahn Aug 19, 2019
d3e229a
Merge cleanup
mfriesenhahn Aug 19, 2019
6c8789c
Merge branch 'audit-links-pwa' of https://github.com/mfriesenhahn/lig…
mfriesenhahn Aug 19, 2019
797e042
update:sample-json
brendankenny Aug 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lighthouse-core/audits/content-width.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ class ContentWidth extends Audit {
failureTitle: 'Content is not sized correctly for the viewport',
description: 'If the width of your app\'s content doesn\'t match the width ' +
'of the viewport, your app might not be optimized for mobile screens. ' +
'[Learn more](https://developers.google.com/web/tools/lighthouse/audits/content-sized-correctly-for-viewport).',
'[Learn more](https://web.dev/content-width).',
requiredArtifacts: ['ViewportDimensions', 'TestedAsMobileDevice'],
};
}
Expand Down
2 changes: 1 addition & 1 deletion lighthouse-core/audits/installable-manifest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ class InstallableManifest extends MultiCheckAudit {
failureTitle: 'Web app manifest does not meet the installability requirements',
description: 'Browsers can proactively prompt users to add your app to their homescreen, ' +
'which can lead to higher engagement. ' +
'[Learn more](https://developers.google.com/web/tools/lighthouse/audits/install-prompt).',
'[Learn more](https://web.dev/installable-manifest).',
requiredArtifacts: ['URL', 'WebAppManifest'],
};
}
Expand Down
2 changes: 1 addition & 1 deletion lighthouse-core/audits/load-fast-enough-for-pwa.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const UIStrings = {
/** Imperative title of a Lighthouse audit that tells the user that their page has loaded fast enough to be considered a Progressive Web App. This imperative title is shown to users when the web page has loaded too slowly to be considered a Progressive Web App. */
failureTitle: 'Page load is not fast enough on mobile networks',
/** Description of a Lighthouse audit that tells the user *why* they need to load fast enough on mobile networks. This is displayed after a user expands the section to see more. No character length limits. 'Learn More' becomes link text to additional documentation. */
description: 'A fast page load over a cellular network ensures a good mobile user experience. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/fast-3g).',
description: 'A fast page load over a cellular network ensures a good mobile user experience. [Learn more](https://web.dev/load-fast-enough-for-pwa).',
/** Label for the audit identifying the time it took for the page to become interactive. */
displayValueText: 'Interactive at {timeInMs, number, seconds}\xa0s',
/** Label for the audit identifying the time it took for the page to become interactive on a mobile network. */
Expand Down
2 changes: 1 addition & 1 deletion lighthouse-core/audits/manual/pwa-cross-browser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ class PWACrossBrowser extends ManualAudit {
return Object.assign({
id: 'pwa-cross-browser',
description: 'To reach the most number of users, sites should work across ' +
'every major browser. [Learn more](https://developers.google.com/web/progressive-web-apps/checklist#site-works-cross-browser).',
'every major browser. [Learn more](https://web.dev/pwa-cross-browser).',
title: 'Site works cross-browser',
}, super.partialMeta);
}
Expand Down
2 changes: 1 addition & 1 deletion lighthouse-core/audits/manual/pwa-each-page-has-url.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class PWAEachPageHasURL extends ManualAudit {
return Object.assign({
id: 'pwa-each-page-has-url',
description: 'Ensure individual pages are deep linkable via the URLs and that URLs are ' +
'unique for the purpose of shareability on social media. [Learn more](https://developers.google.com/web/progressive-web-apps/checklist#each-page-has-a-url).',
'unique for the purpose of shareability on social media. [Learn more](https://web.dev/pwa-each-page-has-url).',
title: 'Each page has a URL',
}, super.partialMeta);
}
Expand Down
2 changes: 1 addition & 1 deletion lighthouse-core/audits/manual/pwa-page-transitions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class PWAPageTransitions extends ManualAudit {
return Object.assign({
id: 'pwa-page-transitions',
description: 'Transitions should feel snappy as you tap around, even on a slow network, a ' +
'key to perceived performance. [Learn more](https://developers.google.com/web/progressive-web-apps/checklist#page-transitions-dont-feel-like-they-block-on-the-network).',
'key to perceived performance. [Learn more](https://web.dev/pwa-page-transitions).',
title: 'Page transitions don\'t feel like they block on the network',
}, super.partialMeta);
}
Expand Down
2 changes: 1 addition & 1 deletion lighthouse-core/audits/offline-start-url.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ class OfflineStartUrl extends Audit {
id: 'offline-start-url',
title: 'start_url responds with a 200 when offline',
failureTitle: 'start_url does not respond with a 200 when offline',
description: 'A service worker enables your web app to be reliable in unpredictable network conditions. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/http-200-when-offline).',
description: 'A service worker enables your web app to be reliable in unpredictable network conditions. [Learn more](https://web.dev/offline-start-url).',
requiredArtifacts: ['WebAppManifest', 'StartUrl'],
};
}
Expand Down
2 changes: 1 addition & 1 deletion lighthouse-core/audits/redirects-http.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ class RedirectsHTTP extends Audit {
title: 'Redirects HTTP traffic to HTTPS',
failureTitle: 'Does not redirect HTTP traffic to HTTPS',
description: 'If you\'ve already set up HTTPS, make sure that you redirect all HTTP ' +
'traffic to HTTPS. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/http-redirects-to-https).',
'traffic to HTTPS. [Learn more](https://web.dev/redirects-http).',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doc seems to give the opposite advice, we want them to redirect their http traffic to https and the doc is mostly talking about avoiding redirects

requiredArtifacts: ['HTTPRedirect'],
};
}
Expand Down
2 changes: 1 addition & 1 deletion lighthouse-core/audits/service-worker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class ServiceWorker extends Audit {
failureTitle: 'Does not register a service worker that controls page and start_url',
description: 'The service worker is the technology that enables your app to use many ' +
'Progressive Web App features, such as offline, add to homescreen, and push ' +
'notifications. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/registered-service-worker).',
'notifications. [Learn more](https://web.dev/service-worker).',
requiredArtifacts: ['URL', 'ServiceWorker', 'WebAppManifest'],
};
}
Expand Down
2 changes: 1 addition & 1 deletion lighthouse-core/audits/splash-screen.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ class SplashScreen extends MultiCheckAudit {
failureTitle: 'Is not configured for a custom splash screen',
description: 'A themed splash screen ensures a high-quality experience when ' +
'users launch your app from their homescreens. [Learn ' +
'more](https://developers.google.com/web/tools/lighthouse/audits/custom-splash-screen).',
'more](https://web.dev/splash-screen).',
requiredArtifacts: ['WebAppManifest'],
};
}
Expand Down
2 changes: 1 addition & 1 deletion lighthouse-core/audits/themed-omnibox.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ class ThemedOmnibox extends MultiCheckAudit {
title: 'Sets an address-bar theme color',
failureTitle: 'Does not set an address-bar theme color',
description: 'The browser address bar can be themed to match your site. ' +
'[Learn more](https://developers.google.com/web/tools/lighthouse/audits/address-bar).',
'[Learn more](https://web.dev/themed-omnibox).',
requiredArtifacts: ['WebAppManifest', 'MetaElements'],
};
}
Expand Down
2 changes: 1 addition & 1 deletion lighthouse-core/audits/viewport.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class Viewport extends Audit {
failureTitle: 'Does not have a `<meta name="viewport">` tag with `width` ' +
'or `initial-scale`',
description: 'Add a viewport meta tag to optimize your app for mobile screens. ' +
'[Learn more](https://developers.google.com/web/tools/lighthouse/audits/has-viewport-meta-tag).',
'[Learn more](https://web.dev/viewport).',
requiredArtifacts: ['MetaElements'],
};
}
Expand Down
2 changes: 1 addition & 1 deletion lighthouse-core/audits/without-javascript.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ class WithoutJavaScript extends Audit {
failureTitle: 'Does not provide fallback content when JavaScript is not available',
description: 'Your app should display some content when JavaScript is disabled, even if ' +
'it\'s just a warning to the user that JavaScript is required to use the app. ' +
'[Learn more](https://developers.google.com/web/tools/lighthouse/audits/no-js).',
'[Learn more](https://web.dev/without-javascript).',
requiredArtifacts: ['HTMLWithoutJavaScript'],
};
}
Expand Down
2 changes: 1 addition & 1 deletion lighthouse-core/audits/works-offline.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class WorksOffline extends Audit {
failureTitle: 'Current page does not respond with a 200 when offline',
description: 'If you\'re building a Progressive Web App, consider using a service worker ' +
'so that your app can work offline. ' +
'[Learn more](https://developers.google.com/web/tools/lighthouse/audits/http-200-when-offline).',
'[Learn more](https://web.dev/works-offline).',
requiredArtifacts: ['Offline', 'URL'],
};
}
Expand Down
2 changes: 1 addition & 1 deletion lighthouse-core/lib/i18n/locales/en-US.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -708,7 +708,7 @@
"message": "Uses HTTPS"
},
"lighthouse-core/audits/load-fast-enough-for-pwa.js | description": {
"message": "A fast page load over a cellular network ensures a good mobile user experience. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/fast-3g)."
"message": "A fast page load over a cellular network ensures a good mobile user experience. [Learn more](https://web.dev/load-fast-enough-for-pwa)."
},
"lighthouse-core/audits/load-fast-enough-for-pwa.js | displayValueText": {
"message": "Interactive at {timeInMs, number, seconds} s"
Expand Down
2 changes: 1 addition & 1 deletion lighthouse-core/lib/i18n/locales/en-XL.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -708,7 +708,7 @@
"message": "Ûśêś ĤT́T̂ṔŜ"
},
"lighthouse-core/audits/load-fast-enough-for-pwa.js | description": {
"message": "Â f́âśt̂ ṕâǵê ĺôád̂ óv̂ér̂ á ĉél̂ĺûĺâŕ n̂ét̂ẃôŕk̂ én̂śûŕêś â ǵôód̂ ḿôb́îĺê úŝér̂ éx̂ṕêŕîén̂ćê. [Ĺêár̂ń m̂ór̂é](https://developers.google.com/web/tools/lighthouse/audits/fast-3g)."
"message": "Â f́âśt̂ ṕâǵê ĺôád̂ óv̂ér̂ á ĉél̂ĺûĺâŕ n̂ét̂ẃôŕk̂ én̂śûŕêś â ǵôód̂ ḿôb́îĺê úŝér̂ éx̂ṕêŕîén̂ćê. [Ĺêár̂ń m̂ór̂é](https://web.dev/load-fast-enough-for-pwa)."
},
"lighthouse-core/audits/load-fast-enough-for-pwa.js | displayValueText": {
"message": "Îńt̂ér̂áĉt́îv́ê át̂ {timeInMs, number, seconds} ś"
Expand Down
28 changes: 14 additions & 14 deletions lighthouse-core/test/results/sample_v2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,37 +37,37 @@
"redirects-http": {
"id": "redirects-http",
"title": "Does not redirect HTTP traffic to HTTPS",
"description": "If you've already set up HTTPS, make sure that you redirect all HTTP traffic to HTTPS. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/http-redirects-to-https).",
"description": "If you've already set up HTTPS, make sure that you redirect all HTTP traffic to HTTPS. [Learn more](https://web.dev/redirects-http).",
"score": 0,
"scoreDisplayMode": "binary"
},
"service-worker": {
"id": "service-worker",
"title": "Does not register a service worker that controls page and start_url",
"description": "The service worker is the technology that enables your app to use many Progressive Web App features, such as offline, add to homescreen, and push notifications. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/registered-service-worker).",
"description": "The service worker is the technology that enables your app to use many Progressive Web App features, such as offline, add to homescreen, and push notifications. [Learn more](https://web.dev/service-worker).",
"score": 0,
"scoreDisplayMode": "binary"
},
"works-offline": {
"id": "works-offline",
"title": "Current page does not respond with a 200 when offline",
"description": "If you're building a Progressive Web App, consider using a service worker so that your app can work offline. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/http-200-when-offline).",
"description": "If you're building a Progressive Web App, consider using a service worker so that your app can work offline. [Learn more](https://web.dev/works-offline).",
"score": 0,
"scoreDisplayMode": "binary",
"warnings": []
},
"viewport": {
"id": "viewport",
"title": "Has a `<meta name=\"viewport\">` tag with `width` or `initial-scale`",
"description": "Add a viewport meta tag to optimize your app for mobile screens. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/has-viewport-meta-tag).",
"description": "Add a viewport meta tag to optimize your app for mobile screens. [Learn more](https://web.dev/viewport).",
"score": 1,
"scoreDisplayMode": "binary",
"warnings": []
},
"without-javascript": {
"id": "without-javascript",
"title": "Contains some content when JavaScript is not available",
"description": "Your app should display some content when JavaScript is disabled, even if it's just a warning to the user that JavaScript is required to use the app. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/no-js).",
"description": "Your app should display some content when JavaScript is disabled, even if it's just a warning to the user that JavaScript is required to use the app. [Learn more](https://web.dev/without-javascript).",
"score": 1,
"scoreDisplayMode": "binary"
},
Expand All @@ -92,7 +92,7 @@
"load-fast-enough-for-pwa": {
"id": "load-fast-enough-for-pwa",
"title": "Page load is fast enough on mobile networks",
"description": "A fast page load over a cellular network ensures a good mobile user experience. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/fast-3g).",
"description": "A fast page load over a cellular network ensures a good mobile user experience. [Learn more](https://web.dev/load-fast-enough-for-pwa).",
"score": 1,
"scoreDisplayMode": "binary",
"numericValue": 4927.278
Expand Down Expand Up @@ -468,7 +468,7 @@
"installable-manifest": {
"id": "installable-manifest",
"title": "Web app manifest does not meet the installability requirements",
"description": "Browsers can proactively prompt users to add your app to their homescreen, which can lead to higher engagement. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/install-prompt).",
"description": "Browsers can proactively prompt users to add your app to their homescreen, which can lead to higher engagement. [Learn more](https://web.dev/installable-manifest).",
"score": 0,
"scoreDisplayMode": "binary",
"explanation": "Failures: No manifest was fetched.",
Expand Down Expand Up @@ -496,7 +496,7 @@
"splash-screen": {
"id": "splash-screen",
"title": "Is not configured for a custom splash screen",
"description": "A themed splash screen ensures a high-quality experience when users launch your app from their homescreens. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/custom-splash-screen).",
"description": "A themed splash screen ensures a high-quality experience when users launch your app from their homescreens. [Learn more](https://web.dev/splash-screen).",
"score": 0,
"scoreDisplayMode": "binary",
"explanation": "Failures: No manifest was fetched.",
Expand All @@ -516,7 +516,7 @@
"themed-omnibox": {
"id": "themed-omnibox",
"title": "Does not set an address-bar theme color",
"description": "The browser address bar can be themed to match your site. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/address-bar).",
"description": "The browser address bar can be themed to match your site. [Learn more](https://web.dev/themed-omnibox).",
"score": 0,
"scoreDisplayMode": "binary",
"explanation": "Failures: No manifest was fetched,\nNo `<meta name=\"theme-color\">` tag found.",
Expand All @@ -538,7 +538,7 @@
"content-width": {
"id": "content-width",
"title": "Content is sized correctly for the viewport",
"description": "If the width of your app's content doesn't match the width of the viewport, your app might not be optimized for mobile screens. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/content-sized-correctly-for-viewport).",
"description": "If the width of your app's content doesn't match the width of the viewport, your app might not be optimized for mobile screens. [Learn more](https://web.dev/content-width).",
"score": 1,
"scoreDisplayMode": "binary",
"explanation": ""
Expand Down Expand Up @@ -1286,7 +1286,7 @@
"offline-start-url": {
"id": "offline-start-url",
"title": "start_url does not respond with a 200 when offline",
"description": "A service worker enables your web app to be reliable in unpredictable network conditions. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/http-200-when-offline).",
"description": "A service worker enables your web app to be reliable in unpredictable network conditions. [Learn more](https://web.dev/offline-start-url).",
"score": 0,
"scoreDisplayMode": "binary",
"explanation": "No usable web app manifest found on page.",
Expand Down Expand Up @@ -1527,21 +1527,21 @@
"pwa-cross-browser": {
"id": "pwa-cross-browser",
"title": "Site works cross-browser",
"description": "To reach the most number of users, sites should work across every major browser. [Learn more](https://developers.google.com/web/progressive-web-apps/checklist#site-works-cross-browser).",
"description": "To reach the most number of users, sites should work across every major browser. [Learn more](https://web.dev/pwa-cross-browser).",
"score": null,
"scoreDisplayMode": "manual"
},
"pwa-page-transitions": {
"id": "pwa-page-transitions",
"title": "Page transitions don't feel like they block on the network",
"description": "Transitions should feel snappy as you tap around, even on a slow network, a key to perceived performance. [Learn more](https://developers.google.com/web/progressive-web-apps/checklist#page-transitions-dont-feel-like-they-block-on-the-network).",
"description": "Transitions should feel snappy as you tap around, even on a slow network, a key to perceived performance. [Learn more](https://web.dev/pwa-page-transitions).",
"score": null,
"scoreDisplayMode": "manual"
},
"pwa-each-page-has-url": {
"id": "pwa-each-page-has-url",
"title": "Each page has a URL",
"description": "Ensure individual pages are deep linkable via the URLs and that URLs are unique for the purpose of shareability on social media. [Learn more](https://developers.google.com/web/progressive-web-apps/checklist#each-page-has-a-url).",
"description": "Ensure individual pages are deep linkable via the URLs and that URLs are unique for the purpose of shareability on social media. [Learn more](https://web.dev/pwa-each-page-has-url).",
"score": null,
"scoreDisplayMode": "manual"
},
Expand Down
Loading