docs(integration-tests): using Lighthouse with Jest; verify in our CI #9722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Shane Exterkamp <[email protected]>
Co-Authored-By: Patrick Hulce <[email protected]>
Co-Authored-By: Brendan Kenny <[email protected]>
connorjclark
commented
Sep 23, 2019
| "test": "jest example-lh-auth.test.js" | ||
| }, | ||
| "dependencies": { | ||
| "jest": "^24.9.0", |
There was a problem hiding this comment.
I also tried to just use ../../../node_modules/.bin/jest, but we are some versions behind and are missing this.utils.DIM_COLOR.
This was referenced Nov 1, 2019
Closed
paulirish
approved these changes
Nov 20, 2019
| * @return {Promise<LH.Result>} | ||
| */ | ||
| async function runLighthouse(url) { | ||
| const result = await lighthouse(url, { |
There was a problem hiding this comment.
shouldnt this also be the impl in example-lh-auth.js ?
that way this file is just tests and no extra stuff.
There was a problem hiding this comment.
This function is short and very relevant to running Lighthouse in tests, so I think it should be here.
connorjclark
changed the title
Co-Authored-By: Paul Irish <[email protected]>
… into integration-docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
split out from #9628