Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clients(devtools): update references to Runtime.cachedResources #9758

Merged
merged 1 commit into from
Sep 30, 2019
Merged

clients(devtools): update references to Runtime.cachedResources #9758

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build/build-dt-report-resources.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ const generatorFilename = `./lighthouse-core/report/report-generator.js`;
const htmlReportAssets = require('../lighthouse-core/report/html/html-report-assets.js');

/**
* Used to save cached resources (Runtime.cachedResources).
* Used to save cached resources (Root.Runtime.cachedResources).
* @param {string} name
* @param {string} content
*/
Expand Down
8 changes: 4 additions & 4 deletions clients/devtools-report-assets.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,14 @@

/**
* @fileoverview Instead of loading report assets form the filesystem, in Devtools we must load
* them via Runtime.cachedResources. We use this module to shim
* them via Root.Runtime.cachedResources. We use this module to shim
* lighthouse-core/report/html/html-report-assets.js in Devtools.
*/

/* global Runtime */
/* global Root */

// @ts-ignore: Runtime exists in Devtools.
const cachedResources = Runtime.cachedResources;
// @ts-ignore: Root.Runtime exists in Devtools.
const cachedResources = Root.Runtime.cachedResources;

// Getters are necessary because the DevTools bundling processes
// resources after this module is resolved. These properties are not
Expand Down