You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We recently started getting CI failures when the package change in #2280 got pulled in indirectly for us, which then resulted in failures with a message like below:
Invalid regular expression: /^(?<!(?:<!-))-->/: Invalid group
If you install the same npm packages on node 10, this works, and we use node 10 locally so we only saw it on CI for Node v8.9.1.
Library Affected:
workbox-webpack-plugin
Browser & Platform:
On build
Issue or Feature Request Description:
Downgrade strip-comments until we're sure it is compatible with Node v8.
The text was updated successfully, but these errors were encountered:
Sorry about that—we do test against Node.js v8 in our automated suite, but I guess that particular code in the third-party module isn't being exercised 😦
Our intention is to support Node.js v8 in the Workbox v5 release, so I'll drop back down to the earlier version of strip-comments.
We recently started getting CI failures when the package change in #2280 got pulled in indirectly for us, which then resulted in failures with a message like below:
If you install the same npm packages on node 10, this works, and we use node 10 locally so we only saw it on CI for Node v8.9.1.
Library Affected:
workbox-webpack-plugin
Browser & Platform:
On build
Issue or Feature Request Description:
Downgrade strip-comments until we're sure it is compatible with Node v8.
The text was updated successfully, but these errors were encountered: