Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer compatible with Node 8 after upgrading strip-comments #2297

Closed
calinoracation opened this issue Dec 2, 2019 · 4 comments · Fixed by #2300
Closed

No longer compatible with Node 8 after upgrading strip-comments #2297

calinoracation opened this issue Dec 2, 2019 · 4 comments · Fixed by #2300
Assignees
Milestone

Comments

@calinoracation
Copy link

We recently started getting CI failures when the package change in #2280 got pulled in indirectly for us, which then resulted in failures with a message like below:

Invalid regular expression: /^(?<!(?:<!-))-->/: Invalid group

If you install the same npm packages on node 10, this works, and we use node 10 locally so we only saw it on CI for Node v8.9.1.

Library Affected:
workbox-webpack-plugin

Browser & Platform:
On build

Issue or Feature Request Description:
Downgrade strip-comments until we're sure it is compatible with Node v8.

@calinoracation
Copy link
Author

calinoracation commented Dec 2, 2019

FWIW, on strip-comments, they assert on the page that they are only node 10+ compatible.

Install with npm (requires Node.js >=10):

We were able to pin workbox-build to 5.0.0-rc.0 before this change occurred to minimize disruption, but that's only a temporary solution.

@jeffposnick
Copy link
Contributor

Sorry about that—we do test against Node.js v8 in our automated suite, but I guess that particular code in the third-party module isn't being exercised 😦

Our intention is to support Node.js v8 in the Workbox v5 release, so I'll drop back down to the earlier version of strip-comments.

@jeffposnick jeffposnick self-assigned this Dec 3, 2019
@jeffposnick jeffposnick added this to the v5 milestone Dec 3, 2019
@codler
Copy link
Contributor

codler commented Dec 4, 2019

Node 8 will have end of life this year end. https://nodejs.org/en/about/releases/ , wouldn't it be better to upgrade to newer node??

@jeffposnick
Copy link
Contributor

Given that it's not Dec. 31 yet, supporting Node v8 for the Workbox v5 release remains our goal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants