Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade strip-comments #2678

Closed
sergey-v9 opened this issue Nov 17, 2020 · 1 comment
Closed

Upgrade strip-comments #2678

sergey-v9 opened this issue Nov 17, 2020 · 1 comment
Labels
workbox-build

Comments

@sergey-v9
Copy link

Library Affected:
workbox-build

Browser & Platform:
webpack (react-scripts)

Issue or Feature Request Description:
Is possible to upgrade strip-comments to 2.0.1 again?
It was done before in #2280, but was reverted in #2300 due to incompatibility with Node 8 (#2415, #2297)
Maybe its time to go forward with this?
@jeffposnick
Copy link
Contributor

It's upgraded to 2.0.1 in the v6 (pre)releases:

workbox/packages/workbox-build/package.json

Line 42 in f2ef912

"strip-comments": "^2.0.1",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
workbox-build
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jeffposnick @sergey-v9 and others