Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precaching and IDB Issues #1111

Merged
merged 1 commit into from
Dec 8, 2017
Merged

Precaching and IDB Issues #1111

merged 1 commit into from
Dec 8, 2017

Conversation

gauntface
Copy link

R: @jeffposnick @addyosmani @philipwalton

The indexedDB wrapper stuff changes but due to my bad tests, I didn't catch any of it. This should fix tests and ensure the format doesn't change in the future.

@workbox-pr-bot
Copy link
Collaborator

PR-Bot Size Plugin

Changed File Sizes

File Before After Change GZipped
packages/workbox-precaching/build/workbox-precaching.prod.js 4.75 KB 4.77 KB +0% 1.86 KB

New Files

No new files have been added.

All File Sizes

View Table
File Before After Change GZipped
packages/workbox-background-sync/build/workbox-background-sync.prod.js 3.17 KB 3.17 KB 0% 1.34 KB
packages/workbox-broadcast-cache-update/build/workbox-broadcast-cache-update.prod.js 1.05 KB 1.05 KB 0% 565 B
packages/workbox-build/build/_types.js 41 B 41 B 0% 61 B
packages/workbox-build/build/index.js 2.52 KB 2.52 KB 0% 1.06 KB
packages/workbox-cache-expiration/build/workbox-cache-expiration.prod.js 3.13 KB 3.13 KB 0% 1.16 KB
packages/workbox-cacheable-response/build/workbox-cacheable-response.prod.js 593 B 593 B 0% 343 B
packages/workbox-cli/build/app.js 4.57 KB 4.57 KB 0% 1.65 KB
packages/workbox-cli/build/bin.js 2.53 KB 2.53 KB 0% 1.07 KB
packages/workbox-core/build/workbox-core.prod.js 6.67 KB 6.67 KB 0% 2.61 KB
packages/workbox-google-analytics/build/workbox-google-analytics.prod.js 1.94 KB 1.94 KB 0% 985 B
packages/workbox-precaching/build/workbox-precaching.prod.js 4.75 KB 4.77 KB +0% 1.86 KB
packages/workbox-range-requests/build/workbox-range-requests.prod.js 1.66 KB 1.66 KB 0% 816 B
packages/workbox-routing/build/workbox-routing.prod.js 2.74 KB 2.74 KB 0% 1.23 KB
packages/workbox-strategies/build/workbox-strategies.prod.js 3.22 KB 3.22 KB 0% 1.00 KB
packages/workbox-sw/build/workbox-sw.js 1.46 KB 1.46 KB 0% 792 B
packages/workbox-webpack-plugin/build/index.js 7.29 KB 7.29 KB 0% 2.45 KB

Workbox Aggregate Size Plugin

☠️ WARNING ☠️

We are using 151% of our max size budget.

Total Size: 22.05KB
Percentage of Size Used: 151%

Gzipped: 8.79KB

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.004%) to 84.772% when pulling 0ec9637 on precaching-idb-fixes into b646c1f on v3.

@gauntface gauntface merged commit fab630f into v3 Dec 8, 2017
@gauntface gauntface deleted the precaching-idb-fixes branch December 8, 2017 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants