Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the log grouping #1116

Merged
merged 1 commit into from
Dec 11, 2017
Merged

Fixing the log grouping #1116

merged 1 commit into from
Dec 11, 2017

Conversation

gauntface
Copy link

R: @jeffposnick @addyosmani @beatrizdemiguelperez

Fixes #1114

This should fix the issue of the grouping getting out of sync in precaching (I looked through the rest of the code base and it shouldn't be an issue.).

@workbox-pr-bot
Copy link
Collaborator

PR-Bot Size Plugin

Changed File Sizes

No file sizes have changed.

New Files

No new files have been added.

All File Sizes

View Table
File Before After Change GZipped
packages/workbox-background-sync/build/workbox-background-sync.prod.js 3.17 KB 3.17 KB 0% 1.34 KB
packages/workbox-broadcast-cache-update/build/workbox-broadcast-cache-update.prod.js 1.05 KB 1.05 KB 0% 565 B
packages/workbox-build/build/_types.js 41 B 41 B 0% 61 B
packages/workbox-build/build/index.js 2.52 KB 2.52 KB 0% 1.06 KB
packages/workbox-cache-expiration/build/workbox-cache-expiration.prod.js 3.13 KB 3.13 KB 0% 1.16 KB
packages/workbox-cacheable-response/build/workbox-cacheable-response.prod.js 593 B 593 B 0% 343 B
packages/workbox-cli/build/app.js 4.57 KB 4.57 KB 0% 1.65 KB
packages/workbox-cli/build/bin.js 2.53 KB 2.53 KB 0% 1.07 KB
packages/workbox-core/build/workbox-core.prod.js 6.67 KB 6.67 KB 0% 2.61 KB
packages/workbox-google-analytics/build/workbox-google-analytics.prod.js 1.94 KB 1.94 KB 0% 985 B
packages/workbox-precaching/build/workbox-precaching.prod.js 4.86 KB 4.86 KB 0% 1.89 KB
packages/workbox-range-requests/build/workbox-range-requests.prod.js 1.66 KB 1.66 KB 0% 816 B
packages/workbox-routing/build/workbox-routing.prod.js 2.74 KB 2.74 KB 0% 1.23 KB
packages/workbox-strategies/build/workbox-strategies.prod.js 3.22 KB 3.22 KB 0% 1.00 KB
packages/workbox-sw/build/workbox-sw.js 1.46 KB 1.46 KB 0% 792 B
packages/workbox-webpack-plugin/build/index.js 7.29 KB 7.29 KB 0% 2.45 KB

Workbox Aggregate Size Plugin

☠️ WARNING ☠️

We are using 151% of our max size budget.

Total Size: 22.14KB
Percentage of Size Used: 151%

Gzipped: 8.81KB

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 84.755% when pulling acf6eca on precaching-logging-fix into a53b3d2 on v3.

@jeffposnick jeffposnick merged commit 1e980d6 into v3 Dec 11, 2017
@jeffposnick jeffposnick deleted the precaching-logging-fix branch December 11, 2017 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants