Warn during multi-compilation scenarios #2245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffposnick
commented
Oct 4, 2019
| @@ -80,6 +81,17 @@ class GenerateSW { | |||
| * @private | |||
| */ | |||
| async handleEmit(compilation) { | |||
| // See https://github.com/GoogleChrome/workbox/issues/1790 | |||
| if (this.alreadyCalled) { | |||
There was a problem hiding this comment.
I was thinking about putting this logic in a reusable module, but it a) relies on instance properties of the plugin and b) relies on the compilation object being available. It ended up being cleaner just duplicating this logic in both plugin classes, but if there are strong feelings, I could refactor.
PR-Bot Size PluginChanged File Sizes
New FilesNo new files have been added. All File SizesView Table
Workbox Aggregate Size Plugin3.51KB gzip'ed (23% of limit) |
philipwalton
approved these changes
Oct 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @philipwalton
This addresses some of #1790 by adding in a
webpackcompilation warning message letting developers know that they shouldn't rely on a consistent set of assets in the precache manifest when the same plugin instance is used across multiple compilations (such as in--watchscenarios).