feat(chrome)!: update the pinned browser version to 131.0.6724.0 #2622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
browser-automation-bot
force-pushed
the
browser-automation-bot/update-browser-version
branch
from
e4183c4 to
340711d
Compare
sadym-chromium
changed the base branch from
sadym/update-browser-version.yml
to
main
sadym-chromium
added
puppeteer
sadym-chromium
force-pushed
the
browser-automation-bot/update-browser-version
branch
from
340711d to
6f8a2c8
Compare
sadym-chromium
approved these changes
Sep 18, 2024
OrKoN
pushed a commit
that referenced
this pull request
Sep 30, 2024
🤖 I have created a release *beep* *boop* --- ## [0.8.0](chromium-bidi-v0.7.1...chromium-bidi-v0.8.0) (2024-09-30) ### ⚠ BREAKING CHANGES * **chrome:** update the pinned browser version to 131.0.6724.0 ([#2622](#2622)) ### Features * `browsingContext.traverseHistory` only for top-level navigables ([#2627](#2627)) ([dd0dec5](dd0dec5)) * **chrome:** update the pinned browser version to 131.0.6724.0 ([#2622](#2622)) ([ff9658a](ff9658a)) ### Bug Fixes * show correct log method ([#2644](#2644)) ([4c66419](4c66419)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
OrKoN
reviewed
Dec 22, 2024
| @@ -118,6 +118,14 @@ export abstract class Realm { | |||
| delete deepSerializedValue['weakLocalObjectReference']; | |||
| } | |||
|
|
|||
| if ( | |||
| (deepSerializedValue as any).type === 'node' && | |||
There was a problem hiding this comment.
This causes a bug in the hasOwn check, we should not cast as any in such case.
OrKoN
added a commit
that referenced
this pull request
Jan 2, 2025
Deeply nested nodes do not include values in CDP, thus, Object.hasOwn throws an error because only objects are allowed as the first arg. Drive-by: improve types Caused by: #2622 Addresses: puppeteer/puppeteer#13433 WPT test: https://github.com/web-platform-tests/wpt/pull/49821/files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically generated by https://github.com/GoogleChromeLabs/chromium-bidi/blob/main/.github/workflows/update-browser-version.yml