Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Cannot read property 'then' of undefined #188

Merged
merged 5 commits into from
Oct 23, 2020

Conversation

leepowelldev
Copy link
Contributor

This PR fixes a Cannot read property 'then' of undefined error that gets thrown when this condition is met:

if (conn = navigator.connection) {
  // Don't prefetch if using 2G or if Save-Data is enabled.
  if (conn.saveData || /2g/.test(conn.effectiveType)) return;
}

prefetch is meant to return a Promise, however in this instance it returns undefined, meaning that this throws:

prefetch(entry.href, options.priority).then(isDone).catch(err => {
  isDone(); if (options.onError) options.onError(err);
});

I tried to add tests for this, but I could not figure out a way of mocking either saveData or a 2g connection - I tried multiple approaches, with none working. If anyone has any ideas then I'm happy to add the tests to cover this.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@leepowelldev
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@leepowelldev
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Copy link
Collaborator

@addyosmani addyosmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Lee!

@addyosmani addyosmani merged commit a8872b8 into GoogleChromeLabs:master Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants