Skip to content
This repository has been archived by the owner on Jun 5, 2023. It is now read-only.

Update the Rollup version restriction from v3.0.0 to v4.0.0 #25

Merged
merged 1 commit into from
Mar 10, 2023
Merged

Update the Rollup version restriction from v3.0.0 to v4.0.0 #25

merged 1 commit into from
Mar 10, 2023

Conversation

sonkkeli
Copy link
Contributor

No description provided.

@sonkkeli sonkkeli requested a review from cmfcmf March 10, 2023 09:57
cmfcmf
cmfcmf reviewed Mar 10, 2023
View reviewed changes
Copy link

@cmfcmf cmfcmf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO we should still keep <4.0.0 here, since we can't yet know whether the plugin will work with Rollup 4.

@sonkkeli sonkkeli changed the title Remove the restriction that Rollup should be under v3.0.0 Update the Rollup version restriction from v3.0.0 to v4.0.0 Mar 10, 2023
@sonkkeli sonkkeli merged commit 304b4bc into GoogleChromeLabs:master Mar 10, 2023
@sonkkeli sonkkeli mentioned this pull request Mar 10, 2023
Closed
@sonkkeli sonkkeli deleted the dont-limit-rollup-upper-version branch March 10, 2023 10:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cmfcmf cmfcmf cmfcmf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sonkkeli @cmfcmf