Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for 3 More Proposals #80

Conversation

CryZe
Copy link
Contributor

@CryZe CryZe commented Sep 16, 2024

  • Adds Support for Exception Handling with exnref
  • Adds Support for JS String Builtins Proposal for WebAssembly
  • Adds Support for Typed function references
  • Renames old exception handling to Legacy Exception Handling

All of these are done to match the latest https://webassembly.org/features/

- Adds Support for `Exception Handling with exnref`
- Adds Support for `JS String Builtins Proposal for WebAssembly`
- Adds Support for `Typed function references`
- Renames old exception handling to `Legacy Exception Handling`
Copy link

google-cla bot commented Sep 16, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Member

@tomayac tomayac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, approval.

Thanks for the PR! Could you make the bot happy by signing the CLA? Then this is good to merge.

@CryZe
Copy link
Contributor Author

CryZe commented Sep 17, 2024

I signed the CLA. The CI failure seems unrelated to either the CLA or my changes.

Binary download from https://nodejs.org/dist/v19.3.0/node-v19.3.0.tar.xz failed, trying source.

@tomayac tomayac merged commit 5129b62 into GoogleChromeLabs:main Sep 17, 2024
1 of 5 checks passed
@tomayac
Copy link
Member

tomayac commented Sep 17, 2024

Released as v1.7.0.

@CryZe CryZe deleted the exnref-js-string-builtins-typed-function-refs branch September 18, 2024 07:48
@surma
Copy link
Collaborator

surma commented Sep 18, 2024

Cheers @CryZe! Appreciate it.

@CryZe
Copy link
Contributor Author

CryZe commented Sep 18, 2024

No problem... though I noticed a bug unfortunately, so I'll have to do a bugfix PR in a few hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants