Move list object API to java storage. #1083
Conversation
shilpi23pandey
force-pushed
the
move-to-java-storage-list-objects
branch
from
ee51416 to
ddcfbfe
Compare
| @@ -90,6 +105,17 @@ public class GoogleCloudStorageClientImpl extends ForwardingGoogleCloudStorage { | |||
| .setDaemon(true) | |||
| .build()); | |||
|
|
|||
| @Nullable | |||
| private static byte[] decodeMetadataValues(String value) { | |||
There was a problem hiding this comment.
We can considering somehow reusing the implementation rather then duplicating the code.
| "listStorageObjectsInternal(%s, %s): item not found", resource, listOptions); | ||
| return null; | ||
| } | ||
| throw new IOException("Error listing " + resource, e); |
There was a problem hiding this comment.
Can we include the e.message as well to the IOException message. Sometime some of the tools just log the message and skip the inner exception details.
| "listStorageObjectsInternal(%s, %s): item not found", resource, listOptions); | ||
| return null; | ||
| } | ||
| throw new IOException("Error listing " + resource, e); |
There was a problem hiding this comment.
Veneer would have retried, correct?
| } | ||
|
|
||
| // Create inferred directory for the prefix object if necessary. | ||
| if (listOptions.isIncludePrefix() |
There was a problem hiding this comment.
Code duplication. Is there a way to avoid this?
| if (maxResults <= 0) { | ||
| return Long.MAX_VALUE; | ||
| } | ||
| return maxResults - blobs.size(); |
There was a problem hiding this comment.
This logic is different from Apiary implementation. Why?
| return maxResults - blobs.size(); | ||
| } | ||
|
|
||
| private static BlobField getBlobField(String field) { |
There was a problem hiding this comment.
Where is this getting used?
| List<BlobListOption> blobListOptions = new ArrayList<>(); | ||
|
|
||
| blobListOptions.add(BlobListOption.pageSize( | ||
| maxResults <= 0 || maxResults >= storageOptions.getMaxListItemsPerCall() |
There was a problem hiding this comment.
why no use Math.min? It might be bit more readable.
| byte[] md5Hash = null; | ||
| byte[] crc32c = null; | ||
|
|
||
| if (!isNullOrEmpty(blob.getCrc32c())) { |
There was a problem hiding this comment.
Please try to avoid code duplication.
shilpi23pandey
force-pushed
the
move-to-java-storage-list-objects
branch
from
ddcfbfe to
611f17f
Compare
shilpi23pandey
force-pushed
the
move-to-java-storage-list-objects
branch
from
611f17f to
e99f850
Compare
No description provided.