This repository has been archived by the owner on Jun 14, 2024. It is now read-only.
v0.2.0 + remove all traces of Gradle Software Model #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@patflynn @meltsufin plugin rewrite. |
It appears that the Gradle Software Model for java projects is
not moving forward. Change code back to classic plugin format -
using extensions and project callbacks.
This code change affects how to configure the plugin now,
the "appengine" configuration block is now under project, not model.
OLD :
model {
appengine {
}
}
NEW :
appengine {
}
loosebazooka
force-pushed
the
changePluginStyle
branch
from
4f96ecf to
61bf4dd
Compare
1. Signing is handled by the nexus plugin 2. Make sure you run --no-daemon when doing an upload
patflynn
reviewed
Sep 26, 2016
| @@ -18,7 +18,7 @@ sourceCompatibility = JavaVersion.VERSION_1_7 | |||
| targetCompatibility = JavaVersion.VERSION_1_7 | |||
|
|
|||
| group = 'com.google.cloud.tools' | |||
| version = '0.1.2-SNAPSHOT' | |||
| version = '0.2.0-SNAPSHOT' | |||
There was a problem hiding this comment.
Why are we still on 0.2.0 if these are 1.0 RC ready?
There was a problem hiding this comment.
For Maven, I was thinking next release would be 1.0.0.
There was a problem hiding this comment.
mostly just because I change a lot of the internals and would like to play around with it for a week before switching to 1.0.0
There was a problem hiding this comment.
or does 1.0.0-rc basically imply the same thing?
|
install comes up with this warning: |
|
Yeah cause you're probably building with java8. You can build with java7 or bypass that warning by specifying the bootstrap class in your build.gradle |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that the Gradle Software Model for java projects is
not moving forward. Change code back to classic plugin format -
using extensions and project callbacks.
This code change affects how to configure the plugin now,
the "appengine" configuration block is now under project, not model.
OLD :
model {
appengine {
}
}
NEW :
appengine {
}