-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from Proto1 to Proto2 #305
Open
srinjoyray
wants to merge
20
commits into
main
Choose a base branch
from
proto2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update all non-major dependencies * Initialize HttpChannel in DelegateConnection to create Violation Listeners. Signed-off-by: Lachlan Roberts <[email protected]> * fix java21 wormhole prober in QA. PiperOrigin-RevId: 665685817 Change-Id: Ie77b14e37dc2384166a3cb2177118907e768c6aa * Fix java21 wormhole prober app flakiness and add simple debug servlet that displays the server properties and env variables to debug the prober. PiperOrigin-RevId: 665890168 Change-Id: Iead610d71033559843b3f7f026b0782510f2da33 * Fix session counting prober being flaky in a test environment having multiple java versions as different appengine service versions causing session collision across runtime tests. PiperOrigin-RevId: 666327671 Change-Id: I4e14ba2d631794b0ab1a3c5f08d2d9251697df5d * Copybara import of the project: -- 0558d79 by Mend Renovate <[email protected]>: Update dependency com.google.cloud:google-cloud-storage to v2.42.0 COPYBARA_INTEGRATE_REVIEW=#261 from renovate-bot:renovate/all-minor-patch 0558d79 PiperOrigin-RevId: 666362344 Change-Id: I1e9094d8949599915dc4fbca558364336dc6b006 * Update all non-major dependencies * Copybara import of the project: -- fd14706 by Mend Renovate <[email protected]>: Update dependency com.google.cloud:google-cloud-datastore to v2.21.2 COPYBARA_INTEGRATE_REVIEW=#262 from renovate-bot:renovate/all-minor-patch fd14706 PiperOrigin-RevId: 667454177 Change-Id: I5cf1b2ccca2bc4af49e83c8805b42e6cbc7f550a * Internal: Remove `-XDinjectLogSites=false` PiperOrigin-RevId: 667770971 Change-Id: I753a96e1a355b574f84ecc79e1cc7aa08774c409 * add markdown file to help with debugging Signed-off-by: Lachlan Roberts <[email protected]> * Improves user documentation PiperOrigin-RevId: 667904863 Change-Id: If726db256e58452bde36d4c3fead9fca764b5fb1 * Adding an empty `debugging.md` so that Webtide can add a corresponding description for it in GitHub. PiperOrigin-RevId: 667961600 Change-Id: Ie4de1a92ff1c55f739771689ada1e1258e614796 * Update all non-major dependencies * ensure flushOnResponseCommit is true for session caches Signed-off-by: Lachlan Roberts <[email protected]> * Copybara import of the project: -- e72dd20 by Mend Renovate <[email protected]>: Update all non-major dependencies COPYBARA_INTEGRATE_REVIEW=#266 from renovate-bot:renovate/all-minor-patch e72dd20 PiperOrigin-RevId: 670816282 Change-Id: Ibc012efcd738a1c1e761cd6e1a753e1028918c74 * Copybara import of the project: -- 3b719dc by Mend Renovate <[email protected]>: Update all non-major dependencies COPYBARA_INTEGRATE_REVIEW=#268 from renovate-bot:renovate/all-minor-patch 3b719dc PiperOrigin-RevId: 671084963 Change-Id: Ibf4c1787c6a229f2784a3d0a68d3ebfec96ff32c * Copybara import of the project: -- 9225e35 by Mend Renovate <[email protected]>: Update all non-major dependencies to v12.0.13 COPYBARA_INTEGRATE_REVIEW=#269 from renovate-bot:renovate/all-minor-patch 9225e35 PiperOrigin-RevId: 672363813 Change-Id: Idda80589798689f15a3bd185e313f4314e5e2031 * Force a change to trigger automation in Kokoro. PiperOrigin-RevId: 672598624 Change-Id: I831dcc996d74e93d2169ab5ff6d7557fa29b843d * Copybara import of the project: -- 82be843 by Mend Renovate <[email protected]>: Update all non-major dependencies COPYBARA_INTEGRATE_REVIEW=#270 from renovate-bot:renovate/all-minor-patch 82be843 PiperOrigin-RevId: 672792324 Change-Id: Ifa4663e05be48787ecfecf4e0e09a1994616ab19 * lazy initialization of AppEngineWebAppContext for HttpConnector mode Signed-off-by: Lachlan Roberts <[email protected]> * Add Mendel experiment to enable Jetty12 for java17 PiperOrigin-RevId: 673573613 Change-Id: Ic588c8dffab7244b4c732b9694a3f4764f87fbbc * Copybara import of the project: -- e18f559 by Mend Renovate <[email protected]>: Update all non-major dependencies COPYBARA_INTEGRATE_REVIEW=#272 from renovate-bot:renovate/all-minor-patch e18f559 PiperOrigin-RevId: 673993076 Change-Id: Iff4137f4e50aa38625bfd379004b76dabc708d69 * Update all non-major dependencies * Update all non-major dependencies * fix customer issue with multiple services where the devappserver does not calculate which runtime ID to pick. A workaround was to set the runtime ID, but we can automatize this. Also correctly set the EE8 and EE10 system properties in local devappserver by reading their value in appengine-web.xml. PiperOrigin-RevId: 675198835 Change-Id: I77643a00feeb70067400eaa5b96ac9cfa1153a84 * Fix the path to the git directory in the release script. Regression introduced when adding AOSS Google secured artifact repository support. PiperOrigin-RevId: 675604299 Change-Id: I22cc78eda434567e29defca6912d31598b3fcbbe * Make all the .sh script 755 so they can be executed in git on borg without doing local changes for execution flag. PiperOrigin-RevId: 675652746 Change-Id: Iad4a5511963c52b64d220b9d2af07f30328825c2 * Disable local checkout for appengine mvn release:perform step. PiperOrigin-RevId: 675722063 Change-Id: Ifc46905f63ce4680ae674f9cfa8b74c75eec6bb0 * Move back to github instead of gob for internal releases. PiperOrigin-RevId: 675761401 Change-Id: I91ecd3acdb6748d238aafaf6e9b6ca91b364f8b1 * Upgrade GAE Java version from 2.0.29 to 2.0.30 and prepare next version 2.0.31-SNAPSHOT PiperOrigin-RevId: 675795466 Change-Id: I457bcad934c9e988096d3a4e88a3ee34c6959a82 --------- Signed-off-by: Lachlan Roberts <[email protected]> Co-authored-by: Mend Renovate <[email protected]> Co-authored-by: GAE Java Team <[email protected]> Co-authored-by: Lachlan Roberts <[email protected]> Co-authored-by: Liam Miller-Cushon <[email protected]> Co-authored-by: Abhinand Sundararajan <[email protected]>
* replaced ProtocolMessage with protobuf.Message * wip * wip * wip * wip
* replaced ProtocolMessage with protobuf.Message * wip * wip * wip * wip * wip
* replaced ProtocolMessage with protobuf.Message * wip * wip * wip * wip * wip * wip * propertyType and propertyValue fix * hardcoded meaning max * fix * added comments * fixed comments - added github path
* proto migration in api_dev * Proto migration for remoteapi
…ependency. Now tests fail because previous change in ApiUtils has a confusion between proto and proto builders. Will look in next PR.
* Update all non-major dependencies * Initialize HttpChannel in DelegateConnection to create Violation Listeners. Signed-off-by: Lachlan Roberts <[email protected]> * fix java21 wormhole prober in QA. PiperOrigin-RevId: 665685817 Change-Id: Ie77b14e37dc2384166a3cb2177118907e768c6aa * Fix java21 wormhole prober app flakiness and add simple debug servlet that displays the server properties and env variables to debug the prober. PiperOrigin-RevId: 665890168 Change-Id: Iead610d71033559843b3f7f026b0782510f2da33 * Fix session counting prober being flaky in a test environment having multiple java versions as different appengine service versions causing session collision across runtime tests. PiperOrigin-RevId: 666327671 Change-Id: I4e14ba2d631794b0ab1a3c5f08d2d9251697df5d * Copybara import of the project: -- 0558d79 by Mend Renovate <[email protected]>: Update dependency com.google.cloud:google-cloud-storage to v2.42.0 COPYBARA_INTEGRATE_REVIEW=#261 from renovate-bot:renovate/all-minor-patch 0558d79 PiperOrigin-RevId: 666362344 Change-Id: I1e9094d8949599915dc4fbca558364336dc6b006 * Update all non-major dependencies * Copybara import of the project: -- fd14706 by Mend Renovate <[email protected]>: Update dependency com.google.cloud:google-cloud-datastore to v2.21.2 COPYBARA_INTEGRATE_REVIEW=#262 from renovate-bot:renovate/all-minor-patch fd14706 PiperOrigin-RevId: 667454177 Change-Id: I5cf1b2ccca2bc4af49e83c8805b42e6cbc7f550a * Internal: Remove `-XDinjectLogSites=false` PiperOrigin-RevId: 667770971 Change-Id: I753a96e1a355b574f84ecc79e1cc7aa08774c409 * add markdown file to help with debugging Signed-off-by: Lachlan Roberts <[email protected]> * Improves user documentation PiperOrigin-RevId: 667904863 Change-Id: If726db256e58452bde36d4c3fead9fca764b5fb1 * Adding an empty `debugging.md` so that Webtide can add a corresponding description for it in GitHub. PiperOrigin-RevId: 667961600 Change-Id: Ie4de1a92ff1c55f739771689ada1e1258e614796 * Update all non-major dependencies * ensure flushOnResponseCommit is true for session caches Signed-off-by: Lachlan Roberts <[email protected]> * Copybara import of the project: -- e72dd20 by Mend Renovate <[email protected]>: Update all non-major dependencies COPYBARA_INTEGRATE_REVIEW=#266 from renovate-bot:renovate/all-minor-patch e72dd20 PiperOrigin-RevId: 670816282 Change-Id: Ibc012efcd738a1c1e761cd6e1a753e1028918c74 * Copybara import of the project: -- 3b719dc by Mend Renovate <[email protected]>: Update all non-major dependencies COPYBARA_INTEGRATE_REVIEW=#268 from renovate-bot:renovate/all-minor-patch 3b719dc PiperOrigin-RevId: 671084963 Change-Id: Ibf4c1787c6a229f2784a3d0a68d3ebfec96ff32c * Copybara import of the project: -- 9225e35 by Mend Renovate <[email protected]>: Update all non-major dependencies to v12.0.13 COPYBARA_INTEGRATE_REVIEW=#269 from renovate-bot:renovate/all-minor-patch 9225e35 PiperOrigin-RevId: 672363813 Change-Id: Idda80589798689f15a3bd185e313f4314e5e2031 * Force a change to trigger automation in Kokoro. PiperOrigin-RevId: 672598624 Change-Id: I831dcc996d74e93d2169ab5ff6d7557fa29b843d * Copybara import of the project: -- 82be843 by Mend Renovate <[email protected]>: Update all non-major dependencies COPYBARA_INTEGRATE_REVIEW=#270 from renovate-bot:renovate/all-minor-patch 82be843 PiperOrigin-RevId: 672792324 Change-Id: Ifa4663e05be48787ecfecf4e0e09a1994616ab19 * lazy initialization of AppEngineWebAppContext for HttpConnector mode Signed-off-by: Lachlan Roberts <[email protected]> * Add Mendel experiment to enable Jetty12 for java17 PiperOrigin-RevId: 673573613 Change-Id: Ic588c8dffab7244b4c732b9694a3f4764f87fbbc * Copybara import of the project: -- e18f559 by Mend Renovate <[email protected]>: Update all non-major dependencies COPYBARA_INTEGRATE_REVIEW=#272 from renovate-bot:renovate/all-minor-patch e18f559 PiperOrigin-RevId: 673993076 Change-Id: Iff4137f4e50aa38625bfd379004b76dabc708d69 * Update all non-major dependencies * Update all non-major dependencies * fix customer issue with multiple services where the devappserver does not calculate which runtime ID to pick. A workaround was to set the runtime ID, but we can automatize this. Also correctly set the EE8 and EE10 system properties in local devappserver by reading their value in appengine-web.xml. PiperOrigin-RevId: 675198835 Change-Id: I77643a00feeb70067400eaa5b96ac9cfa1153a84 * Fix the path to the git directory in the release script. Regression introduced when adding AOSS Google secured artifact repository support. PiperOrigin-RevId: 675604299 Change-Id: I22cc78eda434567e29defca6912d31598b3fcbbe * Make all the .sh script 755 so they can be executed in git on borg without doing local changes for execution flag. PiperOrigin-RevId: 675652746 Change-Id: Iad4a5511963c52b64d220b9d2af07f30328825c2 * Disable local checkout for appengine mvn release:perform step. PiperOrigin-RevId: 675722063 Change-Id: Ifc46905f63ce4680ae674f9cfa8b74c75eec6bb0 * Move back to github instead of gob for internal releases. PiperOrigin-RevId: 675761401 Change-Id: I91ecd3acdb6748d238aafaf6e9b6ca91b364f8b1 * Upgrade GAE Java version from 2.0.29 to 2.0.30 and prepare next version 2.0.31-SNAPSHOT PiperOrigin-RevId: 675795466 Change-Id: I457bcad934c9e988096d3a4e88a3ee34c6959a82 --------- Signed-off-by: Lachlan Roberts <[email protected]> Co-authored-by: Mend Renovate <[email protected]> Co-authored-by: GAE Java Team <[email protected]> Co-authored-by: Lachlan Roberts <[email protected]> Co-authored-by: Liam Miller-Cushon <[email protected]> Co-authored-by: Abhinand Sundararajan <[email protected]>
* replaced ProtocolMessage with protobuf.Message * wip * wip * wip * wip
* replaced ProtocolMessage with protobuf.Message * wip * wip * wip * wip * wip
* replaced ProtocolMessage with protobuf.Message * wip * wip * wip * wip * wip * wip * propertyType and propertyValue fix * hardcoded meaning max * fix * added comments * fixed comments - added github path
* proto migration in api_dev * Proto migration for remoteapi
…ependency. Now tests fail because previous change in ApiUtils has a confusion between proto and proto builders. Will look in next PR.
* Copybara import of the project: -- bbad663 by Mend Renovate <[email protected]>: Update all non-major dependencies COPYBARA_INTEGRATE_REVIEW=#285 from renovate-bot:renovate/all-minor-patch bbad663 PiperOrigin-RevId: 684477251 Change-Id: If7dfb2beb25d1378618a884350ec5d8d4bd3dd46 * Copybara import of the project: -- af7d544 by Mend Renovate <[email protected]>: Update all non-major dependencies COPYBARA_INTEGRATE_REVIEW=#286 from renovate-bot:renovate/all-minor-patch af7d544 PiperOrigin-RevId: 685680510 Change-Id: I96df12dbd2fb7c6eb6cfaae3489626a14766bef9 * Upgrade GAE Java version from 2.0.30 to 2.0.31 and prepare next version 2.0.32-SNAPSHOT PiperOrigin-RevId: 686867662 Change-Id: Id02da08eb160552da419cace43b86c3558e08b0d * Update all non-major dependencies --------- Co-authored-by: Mend Renovate <[email protected]> Co-authored-by: Srinjoy Ray <[email protected]> Co-authored-by: GAE Java Team <[email protected]>
* Copybara import of the project: -- bbad663 by Mend Renovate <[email protected]>: Update all non-major dependencies COPYBARA_INTEGRATE_REVIEW=#285 from renovate-bot:renovate/all-minor-patch bbad663 PiperOrigin-RevId: 684477251 Change-Id: If7dfb2beb25d1378618a884350ec5d8d4bd3dd46 * Copybara import of the project: -- af7d544 by Mend Renovate <[email protected]>: Update all non-major dependencies COPYBARA_INTEGRATE_REVIEW=#286 from renovate-bot:renovate/all-minor-patch af7d544 PiperOrigin-RevId: 685680510 Change-Id: I96df12dbd2fb7c6eb6cfaae3489626a14766bef9 * Upgrade GAE Java version from 2.0.30 to 2.0.31 and prepare next version 2.0.32-SNAPSHOT PiperOrigin-RevId: 686867662 Change-Id: Id02da08eb160552da419cace43b86c3558e08b0d * Update all non-major dependencies * Update all non-major dependencies * Fix multithread build by ensuring jars are build correctly before copy those jars Signed-off-by: Olivier Lamy <[email protected]> --------- Signed-off-by: Olivier Lamy <[email protected]> Co-authored-by: Mend Renovate <[email protected]> Co-authored-by: Srinjoy Ray <[email protected]> Co-authored-by: GAE Java Team <[email protected]> Co-authored-by: Olivier Lamy <[email protected]>
* tests fix * removed extra dependency * wip * wip * fixed testMultiValuePropertySort * fixed test cases * wip - fixing test cases * used getDefaultInstance() * high level changes * wip * wip * review fix * wip fixing tests * wip - fixed DatastoreCallbacksTests * wip * wip - fixed nextCall * fixed tests * Merge main to proto2 tests (#302) * Copybara import of the project: -- bbad663 by Mend Renovate <[email protected]>: Update all non-major dependencies COPYBARA_INTEGRATE_REVIEW=#285 from renovate-bot:renovate/all-minor-patch bbad663 PiperOrigin-RevId: 684477251 Change-Id: If7dfb2beb25d1378618a884350ec5d8d4bd3dd46 * Copybara import of the project: -- af7d544 by Mend Renovate <[email protected]>: Update all non-major dependencies COPYBARA_INTEGRATE_REVIEW=#286 from renovate-bot:renovate/all-minor-patch af7d544 PiperOrigin-RevId: 685680510 Change-Id: I96df12dbd2fb7c6eb6cfaae3489626a14766bef9 * Upgrade GAE Java version from 2.0.30 to 2.0.31 and prepare next version 2.0.32-SNAPSHOT PiperOrigin-RevId: 686867662 Change-Id: Id02da08eb160552da419cace43b86c3558e08b0d * Update all non-major dependencies * Update all non-major dependencies * Fix multithread build by ensuring jars are build correctly before copy those jars Signed-off-by: Olivier Lamy <[email protected]> * Update dependency com.google.cloud:google-cloud-logging to v3.20.5 * Simplity copying dependencies Signed-off-by: Olivier Lamy <[email protected]> * exclude not needed artifacts Signed-off-by: Olivier Lamy <[email protected]> * Do not include runtime-* in WEB-INF/lib Signed-off-by: Olivier Lamy <[email protected]> * Copybara import of the project: -- cb49a97 by Mend Renovate <[email protected]>: Update all non-major dependencies COPYBARA_INTEGRATE_REVIEW=#299 from renovate-bot:renovate/all-minor-patch cb49a97 PiperOrigin-RevId: 690485840 Change-Id: I76205310268bc27e3c1ab56be4d42b6d486f4e4c * Copybara import of the project: -- 05d0d3c by Mend Renovate <[email protected]>: Update all non-major dependencies COPYBARA_INTEGRATE_REVIEW=#299 from renovate-bot:renovate/all-minor-patch 05d0d3c PiperOrigin-RevId: 690870869 Change-Id: I1ba450e60d8637dfd64adb866a5b185b08a744ad * Update all non-major dependencies --------- Signed-off-by: Olivier Lamy <[email protected]> Co-authored-by: Mend Renovate <[email protected]> Co-authored-by: Srinjoy Ray <[email protected]> Co-authored-by: GAE Java Team <[email protected]> Co-authored-by: Olivier Lamy <[email protected]> * Main to proto2-tests (#303) * Copybara import of the project: -- bbad663 by Mend Renovate <[email protected]>: Update all non-major dependencies COPYBARA_INTEGRATE_REVIEW=#285 from renovate-bot:renovate/all-minor-patch bbad663 PiperOrigin-RevId: 684477251 Change-Id: If7dfb2beb25d1378618a884350ec5d8d4bd3dd46 * Copybara import of the project: -- af7d544 by Mend Renovate <[email protected]>: Update all non-major dependencies COPYBARA_INTEGRATE_REVIEW=#286 from renovate-bot:renovate/all-minor-patch af7d544 PiperOrigin-RevId: 685680510 Change-Id: I96df12dbd2fb7c6eb6cfaae3489626a14766bef9 * Upgrade GAE Java version from 2.0.30 to 2.0.31 and prepare next version 2.0.32-SNAPSHOT PiperOrigin-RevId: 686867662 Change-Id: Id02da08eb160552da419cace43b86c3558e08b0d * Update all non-major dependencies * Update all non-major dependencies * Fix multithread build by ensuring jars are build correctly before copy those jars Signed-off-by: Olivier Lamy <[email protected]> * Update dependency com.google.cloud:google-cloud-logging to v3.20.5 * Simplity copying dependencies Signed-off-by: Olivier Lamy <[email protected]> * exclude not needed artifacts Signed-off-by: Olivier Lamy <[email protected]> * Do not include runtime-* in WEB-INF/lib Signed-off-by: Olivier Lamy <[email protected]> * Copybara import of the project: -- cb49a97 by Mend Renovate <[email protected]>: Update all non-major dependencies COPYBARA_INTEGRATE_REVIEW=#299 from renovate-bot:renovate/all-minor-patch cb49a97 PiperOrigin-RevId: 690485840 Change-Id: I76205310268bc27e3c1ab56be4d42b6d486f4e4c * Copybara import of the project: -- 05d0d3c by Mend Renovate <[email protected]>: Update all non-major dependencies COPYBARA_INTEGRATE_REVIEW=#299 from renovate-bot:renovate/all-minor-patch 05d0d3c PiperOrigin-RevId: 690870869 Change-Id: I1ba450e60d8637dfd64adb866a5b185b08a744ad * Update all non-major dependencies --------- Signed-off-by: Olivier Lamy <[email protected]> Co-authored-by: Mend Renovate <[email protected]> Co-authored-by: Srinjoy Ray <[email protected]> Co-authored-by: GAE Java Team <[email protected]> Co-authored-by: Olivier Lamy <[email protected]> * Fix regression that renamed the same proto in 2 different classes during shading... --------- Signed-off-by: Olivier Lamy <[email protected]> Co-authored-by: Ludovic Champenois <[email protected]> Co-authored-by: Mend Renovate <[email protected]> Co-authored-by: GAE Java Team <[email protected]> Co-authored-by: Olivier Lamy <[email protected]>
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
…ne-java-standard into proto2 sync with main
maigovannon
approved these changes
Nov 12, 2024
ludoch
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.