-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update all non-major dependencies #329
Update all non-major dependencies #329
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi team,
I'm currently reviewing this pull request and will provide my feedback shortly. In the meantime, here's a summary for you and other reviewers to quickly get up to speed:
This pull request, submitted by Renovate Bot, updates several non-major dependencies. The primary goal is to keep the project's dependencies current and benefit from bug fixes and improvements in the updated versions.
Here's a breakdown of the changes:
-
Dependency Updates:
org.mockito:mockito-bom
updated from5.14.2
to5.15.2
org.checkerframework:checker-qual
updated from3.48.3
to3.48.4
-
Files Changed:
pom.xml
: Thepom.xml
file was modified to reflect the updated dependency versions (lines 537-543 and 713-719). Specifically, the versions oforg.checkerframework:checker-qual
andorg.mockito:mockito-bom
were updated.
-
Additional Notes: The pull request mentions some dependencies couldn't be looked up. It's recommended to check the Dependency Dashboard for more details.
I'll provide a more detailed review shortly. In the meantime, please review the changes and let me know if you have any questions.
And now, a little haiku to lighten the mood:
Code flows like a stream,
Updates refresh, a new dawn,
Bugs flee in the night.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request updates the org.mockito:mockito-bom
and org.checkerframework:checker-qual
dependencies. It's good practice to keep dependencies up-to-date. Since these are non-major version updates, the risk of introducing breaking changes is low. Please review the release notes below and run your test suite before merging.
Release Notes Summary:
- mockito/mockito (org.mockito:mockito-bom): 5.14.2 -> 5.15.2
- Fix for javadoc publication.
- Bumped org.assertj:assertj-core dependency.
- org.checkerframework:checker-qual: 3.48.3 -> 3.48.4
- No release notes provided. Consult the project's documentation for details.
Recommendations before merging:
- Run your test suite to ensure no regressions were introduced.
@@ -537,7 +537,7 @@ | |||
<dependency> | |||
<groupId>org.checkerframework</groupId> | |||
<artifactId>checker-qual</artifactId> | |||
<version>3.48.3</version> | |||
<version>3.48.4</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a comment explaining the reason for this dependency update. Mentioning specific bug fixes or new features is helpful for future maintainers. This adheres to common style guide practices of commenting changes. I'm referencing a commonly used style guide, since none was explicitly provided.
<version>3.48.4</version> | |
<!-- Updating checker-qual to 3.48.4 for bug fixes. --> | |
<version>3.48.4</version> |
@@ -713,7 +713,7 @@ | |||
<dependency> | |||
<groupId>org.mockito</groupId> | |||
<artifactId>mockito-bom</artifactId> | |||
<version>5.14.2</version> | |||
<version>5.15.2</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to the previous comment, add a comment explaining the reason for updating mockito-bom. This improves maintainability and adheres to common style guide practices. I'm referencing a commonly used style guide, since none was explicitly provided.
<version>5.15.2</version> | |
<!-- Updating mockito-bom to 5.15.2 for javadoc fix. --> | |
<version>5.15.2</version> |
a2a9065
into
GoogleCloudPlatform:main
This PR contains the following updates:
5.14.2
->5.15.2
3.48.3
->3.48.4
Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
mockito/mockito (org.mockito:mockito-bom)
v5.15.2
Compare Source
Changelog generated by Shipkit Changelog Gradle Plugin
5.15.2
Configuration
📅 Schedule: Branch creation - "* 0-3 * * 1" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.