Network dashboard: PSA ranges support, starting with Cloud SQL #1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludoo
reviewed
Dec 21, 2022
blueprints/cloud-operations/network-dashboard/src/plugins/discover-cloudsql.py
Outdated
Show resolved
Hide resolved
|
Aurelien, I'm going to send a patch to reduce the number of loops in the series plugin, and to merge discovery with the existing CAI plugin as there's a ton of code duplication otherwise. |
|
Pushed a refactor, please check if it works for you. |
…oundation-fabric into net-dash-psa
|
One syntax comment: please please do not ever use camel case for variable names... |
ludoo
approved these changes
Dec 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Network dashboard: PSA ranges support, starting with Cloud SQL