Add gc_policy to Bigtable module, bump provider versions to 4.47 #1072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Column families have now a new property, to specify the garbage collection policy. A new option also allows to set a default policy if none is specified. This changes the previous syntax for column families, that was helpful since the policy is column-family specific, the new syntax makes it easier to specify a policy per column family.
|
Israel, we use the same version for all modules and blueprints. Can you bump the provider versions in find . -name versions.tf -exec cp default-versions.tf "{}" \; |
ludoo
added
the
incompatible change
Done. Thanks for the tip, I was not sure about how to bump the version, whether just touching the top level file would "magically" change versions elsewhere or not. |
ludoo
approved these changes
Dec 22, 2022
ludoo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Column families have now a new property, to specify the garbage collection policy. A new option also allows to set a default policy if none is specified.
This changes the previous syntax for column families, that was necessary since the policy is column-family specific. The new syntax makes it easier to specify a policy per column family.
I had to update the default version of the Google TF provider to 4.47, in order to match the latest options available for
google_bigtable_gc_policyresources.