Add support for iam_additive and simplify factory interface in net VPC module
#1259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliocc
requested changes
Mar 17, 2023
juliocc
approved these changes
Mar 17, 2023
lcaggio
pushed a commit
that referenced
this pull request
May 5, 2023
…VPC module (#1259) * initial implementation, no tests * change interface, align tests * add examples ToC * fix variable type, test module-level variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the long-standing request to implement support for subnet additive bindings in the
net-vpcmodule.It also simplifies the subnet factory IAM interface and aligns it with our usual interface in modules, replacing the
iam_groups,iam_usersandiam_service_accountsattributes with a singleiamattribute. This change reduces internal complexity and cognitive overload, and should have a very limited impact on usage.Fixes #1103