Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore entire node config in standard cluster #1348

Merged
merged 1 commit into from
May 2, 2023
Merged

Ignore entire node config in standard cluster #1348

merged 1 commit into from
May 2, 2023

Conversation

ludoo
Copy link
Collaborator

@ludoo ludoo commented May 2, 2023

Fixes #1275

@ludoo ludoo requested review from juliocc and cgrotz May 2, 2023 13:04
@ludoo ludoo enabled auto-merge (squash) May 2, 2023 13:14
cgrotz
cgrotz approved these changes May 2, 2023
View reviewed changes
Copy link
Collaborator

@cgrotz cgrotz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ludoo ludoo merged commit 98c8643 into master May 2, 2023
@ludoo ludoo deleted the ludo/issue-1275 branch May 2, 2023 13:23
lcaggio pushed a commit that referenced this pull request May 5, 2023
@ludoo @lcaggio
ignore entire node config in standard cluster (#1348)
b754eb4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgrotz cgrotz cgrotz approved these changes

@juliocc juliocc Awaiting requested review from juliocc

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Module gke-cluster with "forces replacement" due to deletion of default node pool
2 participants
@ludoo @cgrotz