Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trigger SA for Cloud Run #1404

Merged
merged 1 commit into from
May 30, 2023

Conversation

wiktorn
Copy link
Collaborator

@wiktorn wiktorn commented May 30, 2023

Allows setting service account for triggers in Cloud Run

Copy link
Collaborator

@juliocc juliocc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR! Thanks @wiktorn

@@ -218,6 +218,57 @@ module "cloud_run" {
# tftest modules=1 resources=2 inventory=audit-logs.yaml
```

#### Using custom service accounts for triggers
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the TOC at the beginning of the README?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TOC is only for ### headers, so no need to update TOC unless we want to expand it and add 4th level headers.

@wiktorn wiktorn merged commit 3ac6cea into GoogleCloudPlatform:master May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants