Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Network Load Balancer module #1418

Merged
merged 3 commits into from
Jun 5, 2023
Merged

Network Load Balancer module #1418

merged 3 commits into from
Jun 5, 2023

Conversation

ludoo
Copy link
Collaborator

@ludoo ludoo commented Jun 5, 2023

No description provided.

@ludoo ludoo requested a review from juliocc June 5, 2023 10:47
juliocc
juliocc approved these changes Jun 5, 2023
View reviewed changes
Copy link
Collaborator

@juliocc juliocc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two small comments but LGTM

modules/net-nlb/health-check.tf Show resolved Hide resolved
modules/net-nlb/outputs.tf Show resolved Hide resolved
@ludoo ludoo merged commit ea4c007 into master Jun 5, 2023
@ludoo ludoo deleted the ludo/net-nlb branch June 5, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliocc juliocc juliocc approved these changes

Assignees
No one assigned
Labels
on:documentation on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ludoo @juliocc