Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules/vpc-sc: google_access_context_manager_service_perimeter add support for method_selectors/permission #1439

Conversation

LudovicEmo
Copy link
Contributor

Hello,

modules/vpc-sc is already supporting method_selectors/method for the google_access_context_manager_service_perimeter resource.
This PR adds support for method_selectors/permission.

Example:

resource "google_access_context_manager_service_perimeter" "sp" {
  [REDACTED]
  spec {
    egress_policies { 
      egress_to {
        resources = [
          "projects/111111111111",
        ]
        operations {
          service_name = "bigquery.googleapis.com" 
          method_selectors {
            permission = "bigquery.vpcsc.importData"
          }
        }
    }
  }
  [REDACTED]
}

Reference: https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/access_context_manager_service_perimeters#permission

@google-cla
Copy link

google-cla bot commented Jun 13, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it took us so long to review this, and thanks for the addition!

@ludoo ludoo enabled auto-merge (squash) June 22, 2023 05:54
@ludoo ludoo merged commit 32b347b into GoogleCloudPlatform:master Jun 25, 2023
@LudovicEmo LudovicEmo deleted the LudovicEmo/vpc-sc-service-perimeter-method_selectors-permission branch August 28, 2023 08:36
@LudovicEmo LudovicEmo restored the LudovicEmo/vpc-sc-service-perimeter-method_selectors-permission branch August 28, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants