Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split Cloud Function module in separate v1 and v2 modules #1450

Merged
merged 4 commits into from
Jun 19, 2023
Merged

Split Cloud Function module in separate v1 and v2 modules #1450

merged 4 commits into from
Jun 19, 2023

Conversation

ludoo
Copy link
Collaborator

@ludoo ludoo commented Jun 19, 2023

References #1291

Initial work on splitting the module which will facilitate further improvements. What is done here vs what is captured in the above issue:

  • [ x] split into v1 and v2 modules
  • [x ] Remove _http suffix for v2
  • [ -] Leverage tf1.3 optionals (partial support)
  • Add any missing features
  • Try to make interface similar to Cloud Run
  • Make IAM grants for trigger SA at function level instead of project level

@ludoo ludoo requested review from juliocc, wiktorn and apichick June 19, 2023 10:32
@ludoo ludoo enabled auto-merge (squash) June 19, 2023 10:40
@ludoo ludoo merged commit bd3296b into master Jun 19, 2023
@ludoo ludoo deleted the ludo/cf-module branch June 19, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apichick apichick apichick approved these changes

@juliocc juliocc Awaiting requested review from juliocc

@wiktorn wiktorn Awaiting requested review from wiktorn

Assignees
No one assigned
Labels
on:blueprints on:documentation on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ludoo @apichick