-
Notifications
You must be signed in to change notification settings - Fork 921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose allow_net_admin feature in gke-cluster-autopilot module #1575
Expose allow_net_admin feature in gke-cluster-autopilot module #1575
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the inline comments, please make sure to:
- Update the README.md using the tfdoc script. Review the contributing guide for more details.
- Bump the provider version in default-versions.tf and copy it to versions.tf in every module.
- Sign the CLA
@eunanhardy I can take care of the failing tests |
Thanks @juliocc was just about to ask about that. |
Tests should be fixed now. Once they pass we can go ahead and merge this. Thanks @eunanhardy! |
Raised in this issue #1571
Summary of changes