Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Instance level stateful disk config #1578

Merged
merged 10 commits into from
Aug 11, 2023
Merged

Fix: Instance level stateful disk config #1578

merged 10 commits into from
Aug 11, 2023

Conversation

beardedsamwise
Copy link
Contributor

There are a couple of issues with the compute-mig module with respect to instance level stateful disks:

1 - The example and documentation is misleading and inaccurate. You don't need to know the instance name to create an instance level stateful config, you define the instance you want to create within the MIG and attach any disks you want as stateful
2 - There is a bug in the stateful config where the ID is passed for the instance group manager which results in a 404 when applying.

The requested URL <code>/compute/v1/projects/redactedproject/zones/australia-southeast1-b/instanceGroupManagers/projects/redactedproject/zones/australia-southeast1-b/instanceGroupManagers/mongodb/createInstances?alt=json</code> was not found on this server.

@google-cla
Copy link

google-cla bot commented Aug 8, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ludoo
Copy link
Collaborator

ludoo commented Aug 9, 2023

Can you fix tests?

@ludoo ludoo enabled auto-merge (squash) August 11, 2023 15:00
@ludoo ludoo merged commit b1679ad into GoogleCloudPlatform:master Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants