clusters improvement #1 and #2 #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
danielmarzini
commented
Feb 5, 2022
•
danielmarzini
commented
- decouple initial_node_count from node_count (cannot be set at the same time)
- using project_id as a parameters for the clusters variable to being able to place clusters into different projects
This will give us a way to place clusters in different projects from a single config file
juliocc
requested changes
Feb 5, 2022
There was a problem hiding this comment.
Hey @danielmarzini. Thanks for the PR, see comments below:
Yu have to rebase your branch. Once you do that you'll notice you don't have to do the thing you're doing with bindings in the host project.
The part regarding the project_id seems a little redundant since we're deploying a single project (at least initially) but we can keep it.
The initial_node_count fix is definitely needed since it's currently broken.
juliocc
requested changes
Feb 5, 2022
|
@juliocc removed gke-project-1 and its binding, left there the structure to host future projects addition. wdyt? |
This reverts commit 0444d39.
juliocc
requested changes
Feb 6, 2022
|
@juliocc now adjusted |
juliocc
approved these changes
Feb 6, 2022
juliocc
pushed a commit
that referenced
this pull request
Feb 6, 2022
* shared_vpc_self_link variable from stage2 * removing shared_vpc_self_link * do not initial_node_count as node_count
juliocc
pushed a commit
that referenced
this pull request
Feb 6, 2022
* shared_vpc_self_link variable from stage2 * removing shared_vpc_self_link * do not initial_node_count as node_count
juliocc
pushed a commit
that referenced
this pull request
Feb 7, 2022
* shared_vpc_self_link variable from stage2 * removing shared_vpc_self_link * do not initial_node_count as node_count
juliocc
pushed a commit
that referenced
this pull request
Feb 9, 2022
* shared_vpc_self_link variable from stage2 * removing shared_vpc_self_link * do not initial_node_count as node_count
juliocc
pushed a commit
that referenced
this pull request
Feb 9, 2022
* shared_vpc_self_link variable from stage2 * removing shared_vpc_self_link * do not initial_node_count as node_count
juliocc
pushed a commit
that referenced
this pull request
Feb 10, 2022
* shared_vpc_self_link variable from stage2 * removing shared_vpc_self_link * do not initial_node_count as node_count
juliocc
pushed a commit
that referenced
this pull request
Feb 14, 2022
* shared_vpc_self_link variable from stage2 * removing shared_vpc_self_link * do not initial_node_count as node_count
juliocc
pushed a commit
that referenced
this pull request
Feb 16, 2022
* shared_vpc_self_link variable from stage2 * removing shared_vpc_self_link * do not initial_node_count as node_count
juliocc
pushed a commit
that referenced
this pull request
Feb 28, 2022
* shared_vpc_self_link variable from stage2 * removing shared_vpc_self_link * do not initial_node_count as node_count
juliocc
pushed a commit
that referenced
this pull request
Mar 1, 2022
* shared_vpc_self_link variable from stage2 * removing shared_vpc_self_link * do not initial_node_count as node_count
juliocc
pushed a commit
that referenced
this pull request
Mar 8, 2022
* shared_vpc_self_link variable from stage2 * removing shared_vpc_self_link * do not initial_node_count as node_count
juliocc
pushed a commit
that referenced
this pull request
Mar 18, 2022
* shared_vpc_self_link variable from stage2 * removing shared_vpc_self_link * do not initial_node_count as node_count
danielmarzini
added a commit
that referenced
this pull request
Mar 31, 2022
* shared_vpc_self_link variable from stage2 * removing shared_vpc_self_link * do not initial_node_count as node_count
juliocc
pushed a commit
that referenced
this pull request
Apr 3, 2022
* shared_vpc_self_link variable from stage2 * removing shared_vpc_self_link * do not initial_node_count as node_count
juliocc
pushed a commit
that referenced
this pull request
Apr 27, 2022
* shared_vpc_self_link variable from stage2 * removing shared_vpc_self_link * do not initial_node_count as node_count
juliocc
pushed a commit
that referenced
this pull request
May 5, 2022
* shared_vpc_self_link variable from stage2 * removing shared_vpc_self_link * do not initial_node_count as node_count
juliocc
pushed a commit
that referenced
this pull request
May 27, 2022
* shared_vpc_self_link variable from stage2 * removing shared_vpc_self_link * do not initial_node_count as node_count
juliocc
pushed a commit
that referenced
this pull request
Jun 8, 2022
* shared_vpc_self_link variable from stage2 * removing shared_vpc_self_link * do not initial_node_count as node_count
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.