GKE hub module refactor #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Daniel Marzini <[email protected]>
apichick
force-pushed
the
dmarzi/gke-hub-module-v2
branch
from
b36a96f to
6e1ed43
Compare
apichick
approved these changes
Jul 28, 2022
|
It fails because we require google-beta provider v4.25.0 @ludoo not sure exactly where to change the version, tried to do it in the versions.tf of the module, but didn't work and I was scared of touching the defaults.tf :) |
ludoo
added
on:modules
incompatible change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.